Skip to content

fix(parse): default to angular preset for empty parserOpts#265

Merged
marionebl merged 1 commit intomasterfrom
fix/fallback-to-angular-for-empty-parseropts
Feb 3, 2018
Merged

fix(parse): default to angular preset for empty parserOpts#265
marionebl merged 1 commit intomasterfrom
fix/fallback-to-angular-for-empty-parseropts

Conversation

@marionebl
Copy link
Copy Markdown
Contributor

@marionebl marionebl commented Feb 3, 2018

Changes parse to default to conventional-changelog-angular for empty objects. Previously only falsy values triggered the default.

Motivation and Context

How Has This Been Tested?

  • New unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marionebl marionebl merged commit ccb03b4 into master Feb 3, 2018
@marionebl marionebl deleted the fix/fallback-to-angular-for-empty-parseropts branch February 3, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positives when using the slash symbol ("/") in scope

1 participant

@marionebl