Refactor/armano cli#1998
Merged
escapedcat merged 2 commits intomasterfrom Jul 13, 2020
Merged
Conversation
7 tasks
escapedcat
approved these changes
Jul 13, 2020
|
Hello, Is version Thank you |
Member
|
Please give |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Original PR created at #978
Part of #659
At first i wanted to just migrate it without refactoring, but as [email protected] has horrible type and v6 (current) is just a wrapper for yargs (with horrible types) than we can use yargs directly to reduce complexity.
while reviewing i do recommend to disable whitespaces as diff is getting way more readable
https://github.com/conventional-changelog/commitlint/pull/978/files?utf8=✓&diff=split&w=1
Motivation and Context
Ported cli to typescript as part of #659
How Has This Been Tested?Types of changes
Checklist: