fix(cli): add support for GIT_PARAMS on windows. Closes #103#175
Merged
marionebl merged 2 commits intoconventional-changelog:masterfrom Dec 5, 2017
Merged
Conversation
Contributor
|
I took the liberty to add two new test cases (that were missing in the first place) and added a comment to the implementation explaining why this is needed. Thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The commit adds a new special parser for the
editflag for Windows,so that
$GIT_PARAMScan be read from the command-lineMotivation and Context
commitlint on Windows doesn't work when
$GIT_PARAMSarespecified in the package.json file.
#103
Usage examples
How Has This Been Tested?
Edit:
Types of changes
Checklist: