-
Notifications
You must be signed in to change notification settings - Fork 960
Closed
Labels
Description
Expected Behavior
When using the rule "signed-off-by": [2, "always", "Signed-off-by:"], it doesn't seem to use the parsed commit message when reading in the lines. I would expect the values of lines to be ['subject', 'body', 'Signed-off-by: User [email protected]'].
Current Behavior
The current behaviour includes the comments that are part of .git/COMMIT_EDIT_MSG so it is checking for a 'Signed-off-by' line on the last comment rather than the last actual line of the message, causing it to always fail the check.
Affected packages
- cli
- core
- prompt
- config-angular
Possible Solution
Use the correctly parsed input?
Steps to Reproduce (for bugs)
Make a commit using git commit -s with the setting "signed-off-by": [1, "always", "Signed-off-by:"].
Context
I'm trying to enforce signed commits in our repo.
Your Environment
| Executable | Version |
|---|---|
commitlint --version |
8.3.5 |
git --version |
2.21.1 |
node --version |
v10.16.2 |
Reactions are currently unavailable