update for CheckBitSetModelBase logic #1551
Conversation
|
Hi gdicristofaro, Welcome to ControlsFX and thank you for taking time to contribute to this project. We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ? |
|
Ok. I submitted the CLA. |
controlsfx/src/main/java/org/controlsfx/control/CheckBitSetModelBase.java
Outdated
Show resolved
Hide resolved
|
@abhinayagarwal do you think we can merge this PR (and maybe some others as well) and plan for a release? Thanks! |
|
@abhinayagarwal @eugener @Siedlerchr and others |
|
Apologies for the long delay. The change itself looks okay to me. Can we add a test for this change? |
Hi @abhinayagarwal , I just added a few tests. Let me know if there is anything else. Thank you for your time in maintaining this project. |
@gdicristofaro I wonder whether you checked the example mentioned here |
Sure. Test is included. |
5 participants
Good afternoon to you,
I encountered an issue when I deselected checkboxes for the
CheckComboBoxin a certain order similar to what was discussed in #1550. Looking through the code, I believe this may fix the issue that I was seeing. Thanks for the controls you make available here!