HyperlinkLabel focus property update #1436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxoudela
reviewed
May 2, 2022
| hyperlink.setPadding(new Insets(0, 0, 0, 0)); | ||
| hyperlink.setOnAction(eventHandler); | ||
| hyperlink.focusTraversableProperty().bind(control.focusTraversableProperty()); | ||
| control.focusedProperty().addListener((o, ov, nv) -> { |
Collaborator
There was a problem hiding this comment.
Just a minor concern whether this should be inside a WeakListener or not. I had so many memory leaks in applications because of listener added directly.
Don't know if this one can cause a memory leak or not
Member
Author
There was a problem hiding this comment.
Valid point. I have overridden dispose method to unbind bindings and remove listeners.
Member
Author
There was a problem hiding this comment.
I now use SkinBase#registerChangeListener which is called and gc'd during dispose automatically. Another round of review is appreciated.
Maxoudela
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1321