Skip to content

Fixed NPE while removing items from ObservableList #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhinayagarwal merged 1 commit into from
Apr 24, 2022
Merged

Fixed NPE while removing items from ObservableList #1431

abhinayagarwal merged 1 commit into from
Apr 24, 2022

Conversation

@amitjoy
Copy link
Contributor

@amitjoy amitjoy commented Apr 23, 2022

Fixes #1430

@amitjoy
Copy link
Contributor Author

amitjoy commented Apr 23, 2022 •
edited
Loading

@abhinayagarwal It is also a lurking bug I recently noticed and according to the API contract of ObservableValue#removeListener(ChangeListener), the argument must not be null, otherwise NPE will be thrown. It makes sense to introduce defensive programming for better failsafe approach.

Could you kindly have a look?

abhinayagarwal
abhinayagarwal approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@abhinayagarwal abhinayagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhinayagarwal abhinayagarwal merged commit 0eb3dc6 into controlsfx:master Apr 24, 2022
@amitjoy amitjoy deleted the fix/1430/npe branch June 10, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinayagarwal abhinayagarwal abhinayagarwal approved these changes

Assignees

No one assigned

Labels

CLA-VERIFIED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NPE while removing items from ObservableList that is used in TableView

2 participants

@amitjoy @abhinayagarwal