Action.setSelected(boolean) now triggers the EventHandler if needed, #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi fmichel, Welcome to ControlsFX and thank you for taking time to contribute to this project. We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ? |
controlsfx/src/main/java/org/controlsfx/control/action/Action.java
Outdated
Show resolved
Hide resolved
controlsfx/src/main/java/org/controlsfx/control/action/Action.java
Outdated
Show resolved
Hide resolved
ensuring a coherent application state
fmichel
force-pushed
the
fix/ActionCheck-setSelected-triggerAction
branch
from
dae425e to
3a613e8
Compare
abhinayagarwal
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Using org.controlsfx.control.action.Action.setSelected(boolean) changes the selected state of ActionCheck actions correctly but does not trigger the corresponding EventHandler.
So, changing the state programmatically, using this method, does not make the application do what it would when clicking toogleButton or checkMenu elements created with the ActionCheck (activate or deactivate the rendering of an animation for instance)