Fix notifications #1363
Fix notifications #1363
Conversation
They didn't seems to to anything reasonable and they broke the layouting
Removed the logic to move the close button in the Notifications. It didn't really make sense to me and causes issues.
|
Hi FlorianKirmaier, Welcome to ControlsFX and thank you for taking time to contribute to this project. We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ? |
|
Hi @FlorianKirmaier , Can you please sign the CLA as suggested by the bot? |
|
Done! |
|
Can you update the copyright to |
|
I've updated the copyright dates! |
|
Hi FlorianKirmaier, Welcome to ControlsFX and thank you for taking time to contribute to this project. We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ? |
|
The CLA bot seems to be buggy. |
|
Indeed |
3 participants
Simplified various places in the code.
I think the minHeight is not required, the content should provide the minimum height.
The computeMinHeight/Width methods caused issues. They also were illogical, because graphic is only a small part of it's content.
After this change it seems to work again.
Without this change, and when the graphic is set (for example with .graphic(new Label(text)) )
Then it looked like the following:
I've also removed the VPos logic, because it now always positions it in the center, and it also doesn't really make sense to me.