Skip to content

Conversation

@abhinayagarwal
Copy link
Member

Fixes #1358

@abhinayagarwal
Copy link
Member Author

@danielpeintner Can you review this ?

@danielpeintner
Copy link
Collaborator

@danielpeintner Can you review this ?

I do not have review rights.. ;-)

Anyhow, I looked at the change and I tried the following CSS styling

.combo-box .list-cell {-fx-background: yellow;}
.searchable-combo-box .list-cell {-fx-background: blue;} 

The results show as expected blue entries in searchable combo-boxes and yellow entries in normal combo-boxes.

Having said that, reversing it to

.searchable-combo-box .list-cell {-fx-background: blue;} 
.combo-box .list-cell {-fx-background: yellow;}

does not work as I would expect. Both entries are yellow.

This might be due to CSS rules where I am not super familiar with..

@abhinayagarwal
Copy link
Member Author

Hi @danielpeintner ,

Thanks for the review. Your test results are perfectly normal. The SearchableComboBox is actually a ComboBox and any style-class applied to ComboBox should be applied to the SearchableComboBox as well.

Copy link
Collaborator

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhinayagarwal abhinayagarwal merged commit ae70723 into controlsfx:jfx-13 Apr 17, 2021
@abhinayagarwal abhinayagarwal deleted the issue-1358 branch April 17, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add styleclass to SearchableComboBox

2 participants