Issue #1297: Fix NPE when hitting TAB in CheckComboBox #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please target the PR to |
Maxoudela
approved these changes
Nov 25, 2020
patrick0210
force-pushed
the
issue/1297
branch
2 times, most recently
from
54741ae to
53a17b4
Compare
…a subsequent hit on TAB throws a NullPointerException. This commit fixes the bug.
patrick0210
force-pushed
the
issue/1297
branch
from
53a17b4 to
f5ce440
Compare
patrick0210
changed the title
Member
|
Hi @patrick0210 , Apologies for the delay in reviewing this PR. The fix looks good. Can you please sign the ControlsFX CLA? |
Contributor
Author
|
Hey, |
abhinayagarwal
approved these changes
Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an item gets selected in an CheckComboBox, a subsequent hit on TAB
throws a NullPointerException. This commit fixes this bug.
fixes #1297