Skip to content

flux-operator: Add extraEnvs and hostNetwork options - #11

Merged
stefanprodan merged 2 commits into
controlplaneio-fluxcd:mainfrom
kingdonb:extra-args
Jun 16, 2024
Merged

stefanprodan merged 2 commits into
controlplaneio-fluxcd:mainfrom
kingdonb:extra-args

Conversation

@kingdonb

@kingdonb kingdonb commented Jun 16, 2024 •

Copy link
Copy Markdown
Contributor

Building on #10

Helm chart: add extraEnvs array option (597e086)

I am testing this over at:

https://github.com/kingdonb/cozystack/tree/flux-operator

The cozystack installer has a way of bundling Helm charts internally so it has been relatively easy to verify this chart and check it does what we need 🌮

Testing also here: https://github.com/kingdonb/cozystack-talm-demo

@stefanprodan stefanprodan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changing the values.yaml please run make manifests to regenerate the schema and readme files.

Comment thread charts/flux-operator/values.yaml Resolved
@stefanprodan stefanprodan changed the title Helm chart: add extraEnvs array flux-operator: Add extraEnvs and hostNetwork options Jun 16, 2024
@stefanprodan stefanprodan added the enhancement New feature or request label Jun 16, 2024
* Update charts/flux-operator/values.yaml
* make manifests

Co-authored-by: Stefan Prodan <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
@kingdonb

Copy link
Copy Markdown
Contributor Author

OK, the suggested changes should be in order now 🙇

@stefanprodan stefanprodan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kingdonb

@stefanprodan
stefanprodan merged commit 45a7d3d into controlplaneio-fluxcd:main Jun 16, 2024
@kingdonb
kingdonb deleted the extra-args branch June 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants