[1.57] Fall back from chunked pulls when the chunked metadata is too large and tag as 1.57.1 #2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to split fields by purpose, and document some of the context. For consistency, use the same order in the struct literals. Only reorders existing fields, should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Instead, have the callees produce ErrFallbackToOrdinaryLayerDownload directly. Signed-off-by: Miloslav Trmač <[email protected]>
That's a logically better place, it pairs the getBlobAt calls with the ErrBadRequest types specific to those call sites. We will, also, add more fallback reasons. Signed-off-by: Miloslav Trmač <[email protected]>
... but not if the fallback would be convert_images, again creating too large metadata. Signed-off-by: Miloslav Trmač <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
changed the title
Collaborator
Author
|
Updated to also include the version bump to 1.57.1. |
Member
|
LGTM |
Collaborator
Author
Member
Member
|
I'd prefer to hold for #2241, it's in test mode at the moment. |
Member
|
Closing in favor of #2241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #2230 cherry-picked for the
release-1.57branch.The original PR was LGTMed by @giuseppe , but is not yet merged to
main.