Test github.com/mtrmac/image:mirror-reference#904
Merged
vrothberg merged 2 commits intocontainers:masterfrom May 11, 2020
Merged
Test github.com/mtrmac/image:mirror-reference#904vrothberg merged 2 commits intocontainers:masterfrom
vrothberg merged 2 commits intocontainers:masterfrom
Conversation
mtrmac
changed the title
mtrmac
force-pushed
the
mirror-reference
branch
2 times, most recently
from
52191cf to
2970b0e
Compare
Contributor
Author
|
Re-vendored from merged containers/image#912 . This will cause Skopeo to use an unreleased version of c/image, but I think it’s important to have this test added and enforcing as soon as possible (even if we released c/image within a few days). |
mtrmac
changed the title
Member
|
LGTM |
mtrmac
force-pushed
the
mirror-reference
branch
2 times, most recently
from
41f3deb to
c86bec0
Compare
Member
|
@vrothberg Reping |
vrothberg
reviewed
May 11, 2020
This is an unreleased version of c/image, but it is important to to have the test added in in the next commit enforcing as soon as possible. > go get github.com/containers/image/v5@HEAD > make vendor Signed-off-by: Miloslav Trmač <[email protected]>
... to test the fix for containers/image#912 . Signed-off-by: Miloslav Trmač <[email protected]>
Contributor
Author
|
Rebased, tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: This uses unmerged containers/image#912Vendor in containers/image#912 , and add tests that we are enforcing the correct identities when accessing images through mirrors.