Skip to content

needed working devel branch, hindered by non-existant args.build_arg#179

Closed
jotelha wants to merge 1 commit intocontainers:develfrom
jotelha:20200520_no_args_build_arg
Closed

needed working devel branch, hindered by non-existant args.build_arg#179
jotelha wants to merge 1 commit intocontainers:develfrom
jotelha:20200520_no_args_build_arg

Conversation

@jotelha
Copy link
Copy Markdown
Contributor

@jotelha jotelha commented May 21, 2020

Needed "devices" option only available within devel branch, however devel branch broken as of yesterday due to "orphaned" args.build_arg, probably just WIP, removed here.

Just close pull request if obsolete.

Best,

Johannes

@muayyad-alsadi
Copy link
Copy Markdown
Collaborator

muayyad-alsadi commented May 21, 2020 •
edited
Loading

Can I have a non-working compose file that this PR solve?

@jotelha
Copy link
Copy Markdown
Contributor Author

jotelha commented May 21, 2020

In my particular case, the following file:

version: '3.8'

services:
  mongodb:
    image: mongo-on-smb
    init: true
    restart: always
    build:
        context: ./compose/local/mongodb
        dockerfile: Dockerfile
    container_name: mongodb
    cap_add:
      - CAP_SYS_ADMIN
    devices:
      - /dev/fuse
    ports:
      - "27017:27017"
    environment:
      MONGO_INITDB_ROOT_USERNAME_FILE: /run/secrets/mongodb/username
      MONGO_INITDB_ROOT_PASSWORD_FILE: /run/secrets/mongodb/password
    command: --config /etc/mongod.conf

I don't see args.build_arg set by the compose_up_parse parser, thus calling podman-compose up fails on that compose file within build_one at the modified line.

@jotelha jotelha mentioned this pull request May 22, 2020
Merged
@jotelha
Copy link
Copy Markdown
Contributor Author

jotelha commented May 22, 2020

Will close this one, #180 might resolve the issue in a more favourable way...

@jotelha jotelha closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jotelha @muayyad-alsadi