Skip to content

search endpoint failure correction#5280

Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom
baude:addreturn
Feb 21, 2020
Merged

search endpoint failure correction#5280
openshift-merge-robot merged 1 commit intocontainers:masterfrom
baude:addreturn

Conversation

@baude
Copy link
Member

@baude baude commented Feb 20, 2020

when returning an invalid search, a return was omitted triggering a null on the consumer end.

Fixes: #5228

Signed-off-by: Brent Baude [email protected]

@mheon
Copy link
Member

mheon commented Feb 20, 2020

/approve
LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@jwhonce
Copy link
Member

jwhonce commented Feb 20, 2020

/hold
/lgtm

Cancel hold once tests pass.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 20, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM but the tests are fighting you.

@edsantiago
Copy link
Member

Same thing: #5282. Needs rebase against current master.

I'm sorry, this was just really rotten timing: two simultaneous PRs that just happened to land within hours of each other without a git conflict but causing a real test conflict.

when returning an invalid search, a return was omitted triggering a null on the consumer end.

Fixes: containers#5228

Signed-off-by: Brent Baude <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@baude
Copy link
Member Author

baude commented Feb 21, 2020

rebased

@mheon
Copy link
Member

mheon commented Feb 21, 2020

Restarting failed tests

@edsantiago
Copy link
Member

ARGH. It's the fedora registry flake which I thought I had fixed. I don't see my "sleeping & retrying" messages and am really confused.

I've restarted the two fedora-registry flakes and am looking into the third (podman diff) error.

@mheon
Copy link
Member

mheon commented Feb 21, 2020

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit f51cf85 into containers:master Feb 21, 2020
@baude baude deleted the addreturn branch May 7, 2020 13:09
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APIv2: When /images/search fails do not return null

7 participants