Update mux rules to allow slashes in image names#5235
Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom Feb 18, 2020
Merged
Update mux rules to allow slashes in image names#5235openshift-merge-robot merged 1 commit intocontainers:masterfrom
openshift-merge-robot merged 1 commit intocontainers:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
pkg/api/handlers/utils/images.go
Outdated
Member
There was a problem hiding this comment.
looks like a good fix, but not really related to the slash fix right? I'd prefer a second PR for historicla purposes, but shrug.
Member
|
docs test is failing. |
Member
|
LGTM once things go green |
Member
|
/lgtm |
openshift-ci-robot
added
do-not-merge/hold
Collaborator
|
☔ The latest upstream changes (presumably #5158) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
%2F escaping is also supported. Return better response on bad search terms Fixes containers#5229 Signed-off-by: Jhon Honce <[email protected]>
Member
|
/lgtm |
openshift-ci-robot
added
lgtm
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Feb 19, 2020
PR containers#5235 updated a bunch of entrypoints from {name} to {name:.*}, requiring matching changes to swagger comments. Looks like one got missed due to the manual nature of this work. Have I mentioned lately that manual maintenance of duplicate information is not a great idea? Discrepancy caught by my script, which I would really like to look into getting into CI, but is gating on containers#5238. (I would actually not like to get this script into CI, I would prefer to have the duplicate information be autogenerated from the function calls themselves, but I seem to have lost that battle) Signed-off-by: Ed Santiago <[email protected]>
snj33v
pushed a commit
to snj33v/libpod
that referenced
this pull request
May 31, 2020
PR containers#5235 updated a bunch of entrypoints from {name} to {name:.*}, requiring matching changes to swagger comments. Looks like one got missed due to the manual nature of this work. Have I mentioned lately that manual maintenance of duplicate information is not a great idea? Discrepancy caught by my script, which I would really like to look into getting into CI, but is gating on containers#5238. (I would actually not like to get this script into CI, I would prefer to have the duplicate information be autogenerated from the function calls themselves, but I seem to have lost that battle) Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%2F escaping is also supported.
Fixes #5229
Fixes #5228
Signed-off-by: Jhon Honce [email protected]