Vendor docker/docker, fsouza and more #2#2628
Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom Mar 13, 2019
TomSweeneyRedHat:dev/tsweeney/bigvendorbuildah2
Merged
Vendor docker/docker, fsouza and more #2#2628openshift-merge-robot merged 1 commit intocontainers:masterfrom TomSweeneyRedHat:dev/tsweeney/bigvendorbuildah2
openshift-merge-robot merged 1 commit intocontainers:masterfrom
TomSweeneyRedHat:dev/tsweeney/bigvendorbuildah2
Conversation
Signed-off-by: TomSweeneyRedHat <[email protected]> Vendors in fsouza/docker-client, docker/docker and a few more related. Of particular note, changes to the TweakCapabilities() function from docker/docker along with the parse.IDMappingOptions() function from Buildah. Please pay particular attention to the related changes in the call from libpod to those functions during the review. Passes baseline tests.
openshift-ci-robot
added
approved
Member
Author
vrothberg
reviewed
Mar 13, 2019
| configSpec.Process.Capabilities.Bounding = caplist | ||
| } | ||
| caplist, err = caps.TweakCapabilities(configSpec.Process.Capabilities.Bounding, config.CapAdd, config.CapDrop) | ||
| caplist, err = caps.TweakCapabilities(configSpec.Process.Capabilities.Bounding, config.CapAdd, config.CapDrop, nil, false) |
Member
There was a problem hiding this comment.
I'd like @rhatdan to give this a once-over to be sure it looks OK
Member
Author
There was a problem hiding this comment.
Yes, this is the scariest change in here.
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
LGTM, but I'd like to hold until @rhatdan does a once-over on the capabilities changes |
Member
|
Bizarre. I see no use for the new fields that they added to TweakCapabilities. |
github-actions
bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TomSweeneyRedHat [email protected]
Vendors in fsouza/docker-client, docker/docker and
a few more related. Of particular note, changes to the TweakCapabilities()
function from docker/docker along with the parse.IDMappingOptions() function
from Buildah. Please pay particular attention to the related changes in
the call from libpod to those functions during the review.
Passes baseline tests.