vendor: bump c/common to 9b0d134f392
#25753
Conversation
Bump common to 9b0d134f392f41de3f3065aad162e73a3904168e Signed-off-by: flouthoc <[email protected]>
flouthoc
added
the
No New Tests
|
Followup PR after containers/common#2401 |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
LGTM but lint is unhappy.
SA1019: types.RegexError is deprecated: use [ErrInvalidName] instead. Making linter happy. Signed-off-by: flouthoc <[email protected]>
| NameRegex = types.NameRegex | ||
| // RegexError is thrown in presence of an invalid container/pod name. | ||
| RegexError = types.RegexError | ||
| RegexError = types.ErrInvalidName |
There was a problem hiding this comment.
This works, but maybe the variable could also be renamed.
… does Podman promise a stable API for this package?
There was a problem hiding this comment.
no, we can break that.
The remote client cannot keep type information across the wire anyway so it would be pointless for anyway to try to errors.Is() that in their go client code.
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
/lgtm
In the interest of fixing the breaking vendor change, we can consider changing the error name in podman later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 4b24725
into
containers:main
stale-locking-app
bot
added
the
locked - please file new issue/PR
3 participants
Bump common to 9b0d134f392f41de3f3065aad162e73a3904168e
Does this PR introduce a user-facing change?