rootless: allow to override policy.json by the user#1336
Closed
giuseppe wants to merge 1 commit intocontainers:masterfrom
Closed
rootless: allow to override policy.json by the user#1336giuseppe wants to merge 1 commit intocontainers:masterfrom
giuseppe wants to merge 1 commit intocontainers:masterfrom
Conversation
mheon
reviewed
Aug 24, 2018
libpod/runtime.go
Outdated
Member
There was a problem hiding this comment.
Might be better to do a single lookup for $HOME and use that both here and below
Collaborator
There was a problem hiding this comment.
Not specific to this PR, but XDG_CONFIG_HOME should be honored
Member
Author
There was a problem hiding this comment.
yes good idea, pushed an updated version
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
rootless-set-policy-path
branch
from
990ebdd to
80027a6
Compare
Member
|
LGTM |
Member
Member
|
Looks like travis needs to be kicked again for this. |
| if _, err := os.Stat(newPath); err == nil { | ||
| runtime.config.SignaturePolicyPath = newPath | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
should we error out here if runtime.config.SignaturePolicyPath == "" by the end of this if statement? I think yes, but could be convinced otherwise.
Member
Collaborator
|
📌 Commit 80027a6 has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - status-papr |
github-actions
bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Giuseppe Scrivano [email protected]