remove search domain from response #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Podman will use this as main search domain and ignore everything else then. We don't need to set the search domain at all, aardvark-dns resolves names without it fine. Fixes: containers#1133 Fixes: https://issues.redhat.com/browse/RHEL-83787 Signed-off-by: Paul Holzinger <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
LGTM |
Member
|
/lgtm |
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Apr 7, 2025
A recent change[1] in netavark makes it so we no longer set the default dns.podman search domain. As such we must no longer test for it. [1] containers/netavark#1214 Signed-off-by: Paul Holzinger <[email protected]>
This was referenced Apr 7, 2025
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
May 16, 2025
A recent change[1] in netavark makes it so we no longer set the default dns.podman search domain. As such we must no longer test for it. Follow up to 254ab3b ("test/system: do not check dns.podman") [1] containers/netavark#1214 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/common
that referenced
this pull request
May 27, 2025
Using one KeepHostServers that controls the override of nameservers, search domains and options is not good enough. With netavark 1.15 we dropped the dns.podman search domain[1] as this always overwrote the host search domains which was not correct. However that in turn caused a new issue[2] that a container name might now get resolved to a search domain from the host first. To fix that we either need to revert the dns.podman change or add the ndots:0 option in resolv.conf. Whatever we end up doing we will need one of KeepHostSearches or KeepHostOptions in podman to populate resolv.conf correctly so that we don't overwrite the host domains/options but still can overwrite the nameservers as we want to force aardvark-dns only as nameserver so resolvers cannot bypass it. [1] containers/netavark#1214 [2] containers/podman#26198 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Jun 3, 2025
Using one KeepHostServers that controls the override of nameservers, search domains and options is not good enough. With netavark 1.15 we dropped the dns.podman search domain[1] as this always overwrote the host search domains which was not correct. However that in turn caused a new issue[2] that a container name might now get resolved to a search domain from the host first. To fix that we either need to revert the dns.podman change or add the ndots:0 option in resolv.conf. Whatever we end up doing we will need one of KeepHostSearches or KeepHostOptions in podman to populate resolv.conf correctly so that we don't overwrite the host domains/options but still can overwrite the nameservers as we want to force aardvark-dns only as nameserver so resolvers cannot bypass it. [1] containers/netavark#1214 [2] containers/podman#26198 Signed-off-by: Paul Holzinger <[email protected]> (cherry picked from commit b4bf1f2) Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman will use this as main search domain and ignore everything else then. We don't need to set the search domain at all, aardvark-dns resolves names without it fine.
Fixes: #1133
Fixes: https://issues.redhat.com/browse/RHEL-83787