Small cleanups + one bug fix #2718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
reviewed
Feb 20, 2025
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
LGTM, considering podman 5.5 is set be released in early may I think we can ignore f40 (go 1.22) for it which means we could consider updating to go 1.23 in this release cycle if there is anything specific you would like to take advantage off.
Collaborator
Author
|
(I keep branches containers/skopeo@main...mtrmac:skopeo:go1.23 and mtrmac/image@cleanups...mtrmac:image:go1.23 around, but that’s all code cleanups and rushing to apply them would not benefit users — I think the primary reason to move to Go 1.23 would be to catch up to some dependencies.) |
Member
|
Yes right, there are a few go 1.23 deps already so we should update sooner than later unless someone sees a strong reason why we shouldn't. |
Microoptimize the success case. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Don't update only a private copy of the element. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change (test) behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… discovered while looking at for opportunities to benefit from new features of Go 1.23 and Go 1.24, hence a fairly random collection.
See individual commit messages for details.