copy: Don't print "skipped: 0.0b = 0.00%" #2576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep for more work. Signed-off-by: Colin Walters <[email protected]>
I think this is just visually noisy. If we didn't do a partial fetch then let's just not say anything about it. Signed-off-by: Colin Walters <[email protected]>
mtrmac
approved these changes
Sep 20, 2024
Collaborator
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks! The tests make this really nice to review.
| "github.com/vbauerster/mpb/v8/decor" | ||
| ) | ||
|
|
||
| func TestCustomPartialBlobDecorFunc(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
(This works just fine. In Go, it is idiomatic to have table-driven tests, compare e.g. TestUpdatedBlobInfoFromUpload.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy: Add unit tests for progress output
Prep for more work.
Signed-off-by: Colin Walters [email protected]
copy: Don't print "skipped: 0.0b = 0.00%"
I think this is just visually noisy. If we didn't do a partial
fetch then let's just not say anything about it.
Signed-off-by: Colin Walters [email protected]