Refactor image deletion in OCI #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
oci-delete-refactor
branch
from
8b2204a to
0c12b6c
Compare
Member
|
LGTM |
mtrmac
force-pushed
the
oci-delete-refactor
branch
2 times, most recently
from
4db8981 to
a3c2a85
Compare
Member
Member
|
@kolyshkin PTAL |
... and use slices.Contains instead of a manual loop. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
... so that we don't always create a new map. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
…ation Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
... instead of maintaining two copies. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
…only caller Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
... and document it a bit better Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
oci-delete-refactor
branch
from
a3c2a85 to
f957a9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not change behavior, overall. See individual commits and commit messages for details and an easier-to-review version.