Quote various strings coming from untrusted sources #2408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically, use %q instead of %s (or instead of "%s"), to expose various control characters and the like without interpreting them. This is not really comprehensive; the codebase makes no _general_ guarantee that any returned string values are free of control characters or other malicious/misleading metadata. Not even in returned "error" values (which can legitimately contain newlines, if nothing else). Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
May 9, 2024
Signed-off-by: Miloslav Trmač <[email protected]>
Collaborator
Author
|
See containers/skopeo#2325 for updated Skopeo tests. |
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
May 13, 2024
Signed-off-by: Miloslav Trmač <[email protected]>
cgwalters
approved these changes
May 13, 2024
Contributor
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
I glanced through this and the changes I saw looked good, but I made no attempt to check or look for places that weren't changed.
Member
|
LGTM |
Member
|
Skopeo tests need to be updated. |
Collaborator
Author
|
There is a link to an updated version above. |
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
May 13, 2024
Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added a commit
to containers/skopeo
that referenced
this pull request
May 13, 2024
Update tests for containers/image#2408
TechIsCool
pushed a commit
to TechIsCool/skopeo
that referenced
this pull request
May 15, 2024
Signed-off-by: Miloslav Trmač <[email protected]> Signed-off-by: David Beck <[email protected]>
mtrmac
added a commit
to mtrmac/common
that referenced
this pull request
May 22, 2024
Signed-off-by: Miloslav Trmač <[email protected]>
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/common
that referenced
this pull request
May 22, 2024
Update the libimage/pull_test.go file, changing quote in one line Based on containers/image#2408 from @mtrmac Signed-off-by: tomsweeneyredhat <[email protected]>
Luap99
added a commit
to grisu48/podman
that referenced
this pull request
May 23, 2024
The new c/image version is returning a slightly new error message[1] so make tests use the new one. [1] containers/image#2408 Signed-off-by: Paul Holzinger <[email protected]>
TomSweeneyRedHat
pushed a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
May 29, 2024
The new c/image version is returning a slightly new error message[1] so make tests use the new one. [1] containers/image#2408 Signed-off-by: Paul Holzinger <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically, use
%qinstead of%s(or instead of"%s"), to expose various control characters and the like without interpreting them.This is not really comprehensive; the codebase makes no general guarantee that any returned string values are free of control characters or other malicious/misleading metadata. Not even in returned "error" values (which can legitimately contain newlines, if nothing else).
A side effect of the code audit required by CVE-2024-3727 .