feat: negotiate docker client version #2258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damian Peckett <[email protected]>
Member
|
@mtrmac PTAL |
Member
|
This is a different approach to solving the problem as #2260 |
mtrmac
reviewed
Jan 23, 2024
Collaborator
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
- There is
WithAPIVersionNegotiation; that’s a bit shorter than callingNegotiateAPIVersionexplicitly, and more similar to what the Docker CLI does. - The unit tests run unprivileged, in a fairly arbitrary environment; we can’t assume a running Docker daemon to be available and accepting connections. In particular the proposed test implementation doesn’t work in our CI.
#2260 is, right now, probably not the ideal solution, but it’s a bit closer to it, so let’s discuss there.
mtrmac
added
the
kind/bug
Collaborator
|
#2260 was merged. Still, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding the docker client version we should negotiate a version at runtime. Version 1.22 is very out of date and no longer is supported by modern daemon versions.