Skip to content

Blob reuse decisions do not take into account manifest support #2205

@mtrmac

Description

@mtrmac

E.g. when pushing a schema2 image, dockerImageDestination.TryReusingBlobWithOptions can find and choose to use a Zstd layer

  • That directly breaks if the user forced schema1/schema2 manifest type
  • Even without copy.Options.ForceManifestMIMEType, if the destination is manifest-schema-agnostic, and determineManifestConversion has no reason to expect Zstd to be involved, the copy code will only have a single candidate; we need to either add an OCI manifest schema candidate, or not reuse Zstd layers if the copy is not set up to use OCI.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugA defect in an existing functionality (or a PR fixing it)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions