Fix tests of the ostree transport

mtrmac · mtrmac · commit 807381f448c1 · 2023-07-12T21:17:02.000+02:00
... which I broke on 2022-03-16, and noone noticed.

(The actual non-test code was, at least east as of today, buildable,
so this does not prove that noone is using the code... but it's a
hint in that direction.)

Signed-off-by: Miloslav Trmač &lt;mitr@redhat.com&gt;
diff --git a/ostree/ostree_dest_test.go b/ostree/ostree_dest_test.go
@@ -3,4 +3,8 @@
 
 package ostree
 
+import (
+	"github.com/containers/image/v5/internal/private"
+)
+
 var _ private.ImageDestination = (*ostreeImageDestination)(nil)
diff --git a/ostree/ostree_transport_test.go b/ostree/ostree_transport_test.go
@@ -134,7 +134,7 @@ func TestNewReference(t *testing.T) {
 		require.NoError(t, err, path)
 	}
 
-	_, err = NewReference("busybox", tmpDir+"/thisparentdoesnotexist/something")
+	_, err := NewReference("busybox", tmpDir+"/thisparentdoesnotexist/something")
 	assert.Error(t, err)
 }
 
@@ -239,7 +239,7 @@ func TestReferenceNewImage(t *testing.T) {
 func TestReferenceNewImageSource(t *testing.T) {
 	ref, err := Transport.ParseReference("busybox")
 	require.NoError(t, err)
-	src, err = ref.NewImageSource(context.Background(), nil)
+	src, err := ref.NewImageSource(context.Background(), nil)
 	require.NoError(t, err)
 	defer src.Close()
 }

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ func TestNewReference(t *testing.T) {`
`134`	`134`	`require.NoError(t, err, path)`
`135`	`135`	`}`
`136`	`136`
`137`		`- _, err = NewReference("busybox", tmpDir+"/thisparentdoesnotexist/something")`
	`137`	`+ _, err := NewReference("busybox", tmpDir+"/thisparentdoesnotexist/something")`
`138`	`138`	`assert.Error(t, err)`
`139`	`139`	`}`
`140`	`140`
`@@ -239,7 +239,7 @@ func TestReferenceNewImage(t *testing.T) {`
`239`	`239`	`func TestReferenceNewImageSource(t *testing.T) {`
`240`	`240`	`ref, err := Transport.ParseReference("busybox")`
`241`	`241`	`require.NoError(t, err)`
`242`		`- src, err = ref.NewImageSource(context.Background(), nil)`
	`242`	`+ src, err := ref.NewImageSource(context.Background(), nil)`
`243`	`243`	`require.NoError(t, err)`
`244`	`244`	`defer src.Close()`
`245`	`245`	`}`