fuse-overlayfs: support running without upper layer#133
Merged
rhatdan merged 1 commit intocontainers:masterfrom Oct 20, 2019
Merged
fuse-overlayfs: support running without upper layer#133rhatdan merged 1 commit intocontainers:masterfrom
rhatdan merged 1 commit intocontainers:masterfrom
Conversation
AkihiroSuda
reviewed
Oct 19, 2019
Contributor
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
thanks, but README needs update
when there is no upper layer specified, fail every read operation with EROFS. Closes: containers#100 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
support-no-upperdir
branch
from
2f8991a to
c9bbc94
Compare
Member
Author
thanks, fixed now |
AkihiroSuda
approved these changes
Oct 20, 2019
AkihiroSuda
added a commit
to containerd/fuse-overlayfs-snapshotter
that referenced
this pull request
Oct 20, 2019
Requires: * containerd/containerd#3765 * containers/fuse-overlayfs#133 --- Older commits were imported from containerd with the following commands: git filter-branch --prune-empty --subdirectory-filter snapshots/overlay --msg-filter 'cat; echo; echo This commit was imported from https://github.com/containerd/containerd/commit/${GIT_COMMIT}' master git tag --list | xargs git tag -d Signed-off-by: Akihiro Suda <[email protected]>
Contributor
Member
|
@AkihiroSuda Could something like that be done for CRI-O. |
Contributor
|
CRI-O is using |
Member
|
Ok, I was not quite understanding what your tool was doing. Great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when there is no upper layer specified, fail every read operation with
EROFS.
Closes: #100
Signed-off-by: Giuseppe Scrivano [email protected]