Skip to content

chore(deps): update dependency golangci/golangci-lint to v2.5.0#352

Merged
mtrmac merged 3 commits intomainfrom
renovate/golangci-golangci-lint-2.x
Oct 1, 2025
Merged

chore(deps): update dependency golangci/golangci-lint to v2.5.0#352
mtrmac merged 3 commits intomainfrom
renovate/golangci-golangci-lint-2.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Sep 21, 2025 •
edited
Loading

Note

Mend has cancelled the proposed renaming of the Renovate GitHub app being renamed to mend[bot].

This notice will be removed on 2025-10-07.

This PR contains the following updates:

Package Update Change
golangci/golangci-lint minor v2.4.0 -> v2.5.0

Release Notes

golangci/golangci-lint (golangci/golangci-lint)

v2.5.0

Compare Source

  1. New linters
  2. Linters new features or changes
    • embeddedstructfieldcheck: from 0.3.0 to 0.4.0 (new option: empty-line)
    • err113: from aea10b5 to 0.1.1 (skip internals of Is methods for error type)
    • ginkgolinter: from 0.20.0 to 0.21.0 (new option: force-tonot)
    • gofumpt: from 0.8.0 to 0.9.1 (new rule is to "clothe" naked returns for the sake of clarity)
    • ineffassign: from 0.1.0 to 0.2.0 (new option: check-escaping-errors)
    • musttag: from 0.13.1 to 0.14.0 (support interface methods)
    • revive: from 1.11.0 to 1.12.0 (new options: identical-ifelseif-branches, identical-ifelseif-conditions, identical-switch-branches, identical-switch-conditions, package-directory-mismatch, unsecure-url-scheme, use-waitgroup-go, useless-fallthrough)
    • thelper: from 0.6.3 to 0.7.1 (skip t.Helper in functions passed to synctest.Test)
    • wsl: from 5.1.1 to 5.2.0 (improvements related to subexpressions)
  3. Linters bug fixes
    • asciicheck: from 0.4.1 to 0.5.0
    • errname: from 1.1.0 to 1.1.1
    • fatcontext: from 0.8.0 to 0.8.1
    • go-printf-func-name: from 0.1.0 to 0.1.1
    • godot: from 1.5.1 to 1.5.4
    • gosec: from 2.22.7 to 2.22.8
    • nilerr: from 0.1.1 to a temporary fork
    • nilnil: from 1.1.0 to 1.1.1
    • protogetter: from 0.3.15 to 0.3.16
    • tagliatelle: from 0.7.1 to 0.7.2
    • testifylint: from 1.6.1 to 1.6.4
  4. Misc.
    • fix: "no export data" errors are now handled as a standard typecheck error
  5. Documentation
    • Improve nolint section about syntax

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/golangci-golangci-lint-2.x branch 2 times, most recently from 2835c9f to 375f302 Compare September 25, 2025 17:48
@renovate
chore(deps): update dependency golangci/golangci-lint to v2.5.0
0dd8e77 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/golangci-golangci-lint-2.x branch from 375f302 to 0dd8e77 Compare September 29, 2025 17:19
@github-actions github-actions bot added the common Related to "common" package label Oct 1, 2025
@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Oct 1, 2025

@mtrmac PTAL

podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Oct 1, 2025
@github-actions
dnm: Vendor changes from containers/container-libs#352
3127c3e
@podmanbot
Copy link
Copy Markdown

podmanbot commented Oct 1, 2025

✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6401

@podmanbot podmanbot mentioned this pull request Oct 1, 2025
Closed
@Luap99 Luap99 force-pushed the renovate/golangci-golangci-lint-2.x branch from 1b799b1 to 39327d6 Compare October 1, 2025 11:11
@github-actions github-actions bot added the storage Related to "storage" package label Oct 1, 2025
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Oct 1, 2025
@github-actions
dnm: Vendor changes from containers/container-libs#352
0a9da09
@podmanbot
Copy link
Copy Markdown

podmanbot commented Oct 1, 2025

✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6402

@podmanbot podmanbot mentioned this pull request Oct 1, 2025
Closed
@Luap99
fix golangci-lint errors with v2.5.0
b8a599f 
Just some minor formatting changes from gofumpt.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 force-pushed the renovate/golangci-golangci-lint-2.x branch from 39327d6 to b8a599f Compare October 1, 2025 11:19
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Oct 1, 2025
@github-actions
dnm: Vendor changes from containers/container-libs#352
8fc7860
@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Oct 1, 2025

I wonder if we need an opt out of this create downstream PR workflow? A chnage like this really does not benefit from it and I though when I closed the buildah PR it would just be fine but it seem repushes just create a new PR then?

cc @flouthoc

@flouthoc
Copy link
Copy Markdown
Contributor

flouthoc commented Oct 1, 2025

I wonder if we need an opt out of this create downstream PR workflow? A chnage like this really does not benefit from it and I though when I closed the buildah PR it would just be fine but it seem repushes just create a new PR then?

cc @flouthoc

We can not enable this workflow on PR with dependencies label ? or we can have a label defined to not supress this workflow ?

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Oct 1, 2025

I wonder if we need an opt out of this create downstream PR workflow? A chnage like this really does not benefit from it and I though when I closed the buildah PR it would just be fine but it seem repushes just create a new PR then?
cc @flouthoc

We can not enable this workflow on PR with dependencies label ? or we can have a label defined to not supress this workflow ?

I don't want to gate on the dependency label, we already have the path conditions setup so it trigger on the renovate commit. What happened I fixed a bunch of basic lint errors that I know won't affect podman/buildah in any way so it would be nice to have a way to skip it (via label should be fine) that I can apply before I push that change mainly to avoid the CI time and churn on the other repos.

mtrmac
mtrmac reviewed Oct 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Luap99 !

I think, if we are going to have these linters, let’s take advantage of them by expressing (in this case) the error handling code paths as explicitly as possible.

(I’m generally not a fan of zealously enabling non-default linters, so I would not be too opposed to disabling that linter instead… but, also, I’ve been severely bitten by named return values previously.)

@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented Oct 1, 2025

I have ~no opinion on dependency-only updates.

For a situation like this, where we do change some of our code, I lean towards thinking that machine time is cheap, and it is possible for bugs to sneak in via one tiny oversight among a few dozen small changes of this kind. I’m not saying that we absolutely must not have an “opt-out” label — rather, that we should not get into the habit of thinking “let’s save a few pennies by not testing this PR, I think it’s good”.

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Oct 1, 2025

(I’m generally not a fan of zealously enabling non-default linters, so I would not be too opposed to disabling that linter instead… but, also, I’ve been severely bitten by named return values previously.)

I hate named returns so I very much like this change, also since it isn't clear this is not a new linter but the gofumpt formatter seems to change this now by default and thus the linter checking the formatting is complaining. Certainly we could disable gofumpt linter but overall this seems a good thing.

For a situation like this, where we do change some of our code, I lean towards thinking that machine time is cheap, and it is possible for bugs to sneak in via one tiny oversight among a few dozen small changes of this kind. I’m not saying that we absolutely must not have an “opt-out” label — rather, that we should not get into the habit of thinking “let’s save a few pennies by not testing this PR, I think it’s good”.

fair enough

@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Oct 1, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Oct 1, 2025

Ok I did "simplify" a bit futher by removing a bunch of named return params where they don't really add anything IMO.

podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Oct 1, 2025
@github-actions
dnm: Vendor changes from containers/container-libs#352
7e7c67e
mtrmac
mtrmac reviewed Oct 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM after one more change, please merge directly afterwards.

@Luap99 Luap99 force-pushed the renovate/golangci-golangci-lint-2.x branch from afd031e to da86a60 Compare October 1, 2025 16:35
@Luap99
simplify named returns further
f787ee6 
With the linter enforcing the proper return statements we don't need to
define the named return parameter in many cases.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 force-pushed the renovate/golangci-golangci-lint-2.x branch from da86a60 to f787ee6 Compare October 1, 2025 16:36
@packit-as-a-service
Copy link
Copy Markdown

packit-as-a-service bot commented Oct 1, 2025

Packit jobs failed. @containers/packit-build please check.

podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Oct 1, 2025
@github-actions
dnm: Vendor changes from containers/container-libs#352
f6c3881
@mtrmac mtrmac enabled auto-merge October 1, 2025 16:39
@mtrmac mtrmac merged commit c8ce68e into main Oct 1, 2025
29 of 36 checks passed
@renovate renovate bot deleted the renovate/golangci-golangci-lint-2.x branch October 1, 2025 16:57
@mtrmac mtrmac mentioned this pull request Oct 1, 2025
Closed
1 task
@Luap99 Luap99 mentioned this pull request Oct 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrmac mtrmac mtrmac approved these changes

Assignees

No one assigned

Labels

common Related to "common" package dependencies storage Related to "storage" package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Luap99 @podmanbot @flouthoc @mtrmac