SecretsManager - support ignore flag to noop if already exists #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideAdds an IgnoreIfExists option to the SecretsManager.Store method, enforces mutual exclusivity with the existing Replace option, and updates Store logic to no-op when ignoring an already existing secret; test coverage is added for these scenarios. Class diagram for updated StoreOptions and SecretsManager.StoreclassDiagram
class StoreOptions {
map~string, string~ Labels
bool Replace
bool IgnoreIfExists
}
class SecretsManager {
Store(name string, data []byte, driverType string, options StoreOptions) (string, error)
}
SecretsManager --> StoreOptions : uses
Flow diagram for SecretsManager.Store logic with IgnoreIfExists and Replaceflowchart TD
A[Start Store] --> B{Data size valid?}
B -- No --> Z[Return errDataSize]
B -- Yes --> C{IgnoreIfExists && Replace?}
C -- Yes --> Y[Return errIgnoreIfExistsAndReplace]
C -- No --> D{Secret exists?}
D -- No --> E[Create new Secret]
D -- Yes --> F{Replace or IgnoreIfExists?}
F -- No --> G[Return errSecretNameInUse]
F -- IgnoreIfExists --> H[Return existing Secret ID]
F -- Replace --> I[Update existing Secret]
E --> J[Return new Secret ID]
I --> J
H --> J
G --> J
Y --> J
Z --> J
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
secret-create-ignore
branch
from
5baf72d to
e5e3f5e
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Contributor
Author
|
@Luap99 this is the PR to complement: containers/podman#26467 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, sourcery-ai[bot], ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
@contaers/maintainers PTAL |
Contributor
Author
|
@containers/common-maintainers PTAL |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhance SecretsManager.Store to support an ignore-if-exists flag with proper validation and add corresponding tests
New Features:
Bug Fixes:
Enhancements:
Tests: