Skip to content

update github.com/opencontainers/runc to v1.3.0 #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 16, 2025
Merged

update github.com/opencontainers/runc to v1.3.0 #2443

openshift-merge-bot merged 1 commit into from
May 16, 2025

Conversation

@Luap99
Copy link
Member

@Luap99 Luap99 commented May 16, 2025 •
edited by sourcery-ai bot
Loading

And fix some deprecated types.

Summary by Sourcery

Upgrade runc dependency to v1.3.0 and adapt device parsing logic to the updated config.Device API, including corresponding vendoring and deprecated type adjustments.

Enhancements:

  • Migrate DeviceFromPath to return config.Device and use config.Permissions instead of libcontainer/devices types in pkg/parse/parse_unix.go

Build:

  • Bump github.com/opencontainers/runc to v1.3.0 in go.mod and update vendored code

@Luap99
update github.com/opencontainers/runc to v1.3.0
4533ebe 
And fix some deprecated types.

Signed-off-by: Paul Holzinger <[email protected]>
@sourcery-ai
Copy link

sourcery-ai bot commented May 16, 2025 •
edited
Loading

Reviewer's Guide

This PR bumps the opencontainers/runc dependency to v1.3.0, replaces deprecated libcontainer device APIs with the new config.Device types, and refreshes the vendored runc modules accordingly.

File-Level Changes

Change Details Files
Upgrade runc dependency to v1.3.0 and refresh vendor tree
  • Bump runc version in go.mod
  • Update go.sum to match new dependency
  • Regenerate vendor files, adding/removing runc sources
 go.mod
go.sum
vendor/*
Migrate DeviceFromPath to use config.Device and config.Permissions
  • Import github.com/opencontainers/cgroups/devices/config
  • Change function return type from []devices.Device to []config.Device
  • Adjust slice allocations and Permissions calls to use config types
 pkg/parse/parse_unix.go
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99 Luap99 mentioned this pull request May 16, 2025
Closed
1 task
sourcery-ai[bot]
sourcery-ai bot suggested changes May 16, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Luap99 - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Cannot append *devices.Device to a []config.Device slice directly (link)
Here's what I looked at during the review
  • 🔴 General issues: 1 blocking issue, 1 other issue
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mtrmac
Copy link
Contributor

mtrmac commented May 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 01126e4 into containers:main May 16, 2025
14 checks passed
@Luap99 Luap99 deleted the runc-1.3.0 branch May 17, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mtrmac mtrmac

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Luap99 @mtrmac