Update c/image to main #2333
Update c/image to main #2333
Conversation
| // 0-2,3,1 | ||
| // | ||
| // Deprecated: ParseUintList was only used internally and will be removed in the next release. | ||
| func ParseUintList(val string) (map[int]bool, error) { |
There was a problem hiding this comment.
This is called from pkg/sysinfo/sysinfo.go , so further updates might be needed.
There was a problem hiding this comment.
… and they are.
Podman also calls this function; I guess c/common will need to carry it?
There was a problem hiding this comment.
I think so, maybe copy it to pkg/parse here.
There was a problem hiding this comment.
Note I wrote pkg/parse intentionally, not pkg/parsers.
While moving 1 to 1 like this makes sense I find it quite hard for callers to justify why there is a parse and parsers package here. (Not that most of the package structure makes sense here but we should not make it worse)
There was a problem hiding this comment.
Note I wrote
pkg/parseintentionally, notpkg/parsers.
I’m sorry, I missed that.
I also missed something I should have checked sooner: we are already carrying a copy in c/storage; so, I have modified this PR to use that one, and now c/common has no direct dependency on Docker. I don’t think that helps all that much, Podman will still need to adjust for deprecations.
There was a problem hiding this comment.
Ack, yeah makes sense top use c/storage if we already carry the copy anyway there
mtrmac
force-pushed
the
c-image-for-docker
branch
2 times, most recently
from
087ebb0 to
56018d9
Compare
|
LGTM on my end. I'm fine with the current |
…List It is deprecated in the docker repo as of v28. We are already carrying a variant in c/storage. Signed-off-by: Miloslav Trmač <[email protected]>
... primarily to update docker/docker to v28; that broke API, so we need to update the c/image caller as well. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
c-image-for-docker
branch
from
56018d9 to
c8a5c6e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
... primarily to update docker/docker to v28; that broke API, so we need to update the c/image caller as well.
This is a superset of #2328 ; only updating
docker/dockerdoes not work.