Skip to content

Conversation

@ericcurtin
Copy link
Member

No description provided.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin
Copy link
Member Author

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericcurtin, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericcurtin
Copy link
Member Author

ericcurtin commented Jan 24, 2025

@vrothberg if you know how to get this merged that would be great 😄

I don't how the merge process works in this repo.

@vrothberg
Copy link
Member

@vrothberg if you know how to get this merged that would be great 😄

The policy is two LGTMs by maintainers. Unfortunately, my power ends with one :^)

@ericcurtin
Copy link
Member Author

Ah I see! @mheon @baude wanna give us a review?

@mheon
Copy link
Member

mheon commented Jan 24, 2025

Sure
/lgtm

@vrothberg
Copy link
Member

vrothberg commented Jan 24, 2025

Once in, you can open a PR against https://github.com/containers/.github/ to show the logo by default 👍

@openshift-merge-bot openshift-merge-bot bot merged commit fa339b6 into containers:main Jan 24, 2025
15 checks passed
@ericcurtin ericcurtin deleted the ramalama branch January 24, 2025 13:21
@ericcurtin
Copy link
Member Author

It's here if you guys have review permissions in this repo also:

containers/.github#16

@vrothberg @mheon @baude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants