Only reset compression if its not valid #2255
Conversation
|
@mtrmac Hi Miroslav, long time :) I think the failure in the podman test PR is an infra failure, but if I'm wrong lmk and I'll try and work out what happened. |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
Logic LGTM; it would be best to see containers/podman#24673 be reviewed and mostly-pass before merging this.
Jamstah
force-pushed
the
allow-forced-gzip-on-v2s2
branch
from
8ceb2ec to
ff282b1
Compare
If we reset the default compression method, force compression no longer works. Signed-off-by: James Hewitt <[email protected]>
Jamstah
force-pushed
the
allow-forced-gzip-on-v2s2
branch
from
ff282b1 to
b6b2a9a
Compare
|
Review comments addressed and push to both PRs for testing. |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
LGTM. Note to self: Merge after the test PR passes.
Thanks!
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jamstah, Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
If we reset the default compression method, force compression no longer works.
Fixes containers/podman#23942
Podman test containers/podman#24673