CI: enable extra linters for new code #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea here is to run some more picky linters only on new code, so we can keep the existing code as is, but impose some additional requirements to any new code. Currently, this enables godot linter which wants all comments to have a period at the end of the sentence. This makes sense because otherwise some comments might be read as unfinished. Obviously, no one wants to fix all the existing comments to have periods, but this will impose such requirement onto any new code (which also includes the code that is moved around). Signed-off-by: Kir Kolyshkin <[email protected]>
saschagrunert
approved these changes
May 17, 2022
Member
saschagrunert
left a comment
saschagrunert
left a comment
There was a problem hiding this comment.
This is a cool approach, LGTM!
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, rhatdan, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to run some more picky linters only on new code,
so we can keep the existing code as is, but impose some additional
requirements to any new code.
Currently, this enables godot linter which wants all comments to have a
period at the end of the sentence. This makes sense because otherwise
some comments might be read as unfinished.
Obviously, no one wants to fix all the existing comments to have
periods, but this will impose such requirement onto any new code
(which also includes the code that is moved around).
Hope that makes sense.