copier.Get(): try to avoid descending into directories by nalind · Pull Request #3486 · containers/buildah

nalind · 2021-08-27T17:49:05Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

When processing a directory tree, only descend into a directory that is marked for exclusion if its path is literally a prefix of an exception pattern.

Subtly, but in a way that's compatible with docker, this means that if we exclude directory "subdir", but we've been told to also include **/file (with an exclusion pattern of !**/file), we won't descend into "subdir" and find a file named "subdir/file", because "**/file" doesn't start with "subdir/".

More generally, exclusion patterns that start with "!" which include any wildcards before their final component technically won't be treated correctly.

How to verify it

It's rather difficult to create the permissions-based error that we can encounter when we attempt to descend into a directory that we can't read, but which wouldn't contain anything we'd include if we could read it, as described in #3427, when the tests are running as root, but there's a new conformance test that confirms that we at least don't do the technically-correct-but-incompatible thing.

Which issue(s) this PR fixes:

Should fix #3427.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

rhatdan · 2021-08-27T18:04:54Z

LGTM

TomSweeneyRedHat · 2021-08-28T00:12:22Z

Changes LGTM, but you're still thumb wrestling with the tests.

When processing a directory tree, only descend into a directory that is marked for exclusion if its path is literally a prefix of an exception pattern. Subtly, but in a way that's compatible with docker, this means that if we exclude directory "subdir", but we've been told to also include "**/file" (with an exclusion pattern of "!**/file"), we won't descend into "subdir" and find a file named "subdir/file", because "**/file" doesn't start with "subdir/". More generally, exclusion patterns that start with "!" which include any wildcards before their final component technically won't be treated correctly. Signed-off-by: Nalin Dahyabhai <[email protected]>

Add a --max-parallel-downloads flag to allow tuning down from the default of six blobs at a time, and tune it down to one at a time when we invoke the helper. Signed-off-by: Nalin Dahyabhai <[email protected]>

TomSweeneyRedHat · 2021-08-30T23:51:06Z

LGTM
and happy green test buttons. @vrothberg PTAL and merge if it LGTY

vrothberg

/lgtm

openshift-ci · 2021-08-31T07:38:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nalind,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fix copy tests after containers/buildah#3486 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <[email protected]>

We adjust the LICENSE checksum due to: commit 84694170402ff699065382ba2d2fb172c3b6c88f Author: Daniel J Walsh <[email protected]> Date: Thu Aug 26 13:15:23 2021 -0400 Globally replace http:// with https:// [NO TESTS NEEDED] Hopefully existing tests will find issues. Signed-off-by: Daniel J Walsh <[email protected]> and import the following changes: 6e8de00bb Bump to v3.4.0 3c93afbf4 Final release notes update for v3.4.0 128e168be Support selinux options with bind mounts play/gen 855746cc9 Fix release notes 09b353081 Release notes for v3.4.0 final release 2247d5f1b Disable docker and alias to podman in FCOS ignition 7d72e8324 [NO TESTS NEEDED] Add port configuration to first regular container 4fc40c82f Remind user to check connection or use podman machine 5064fd519 Ensure pod ID bucket is properly updated on rename ba74d6e6e libpod: do not call (*container).Config() a1199dbaf [CI:DOCS] cmd/podman: no dot for short descriptions ddc2b9bbe System tests: speed up. They've gotten too slow. b3af5a92c stop: Do nothing if container was never created in runtime 7bfc5250d remote build: EvalSymlinks() the context directory 7395459c7 podman machine: do not join userns 5e9aa13dc added healthcheck to ps command 6638a91e8 Fix english on prune prompt 31df5b78f rootful: do not set XDG_RUNTIME_DIR for cni plugins 8c944274f Revert "rootful: unset XDG_RUNTIME_DIR" 6ef2d3bd8 shell completion: do not show images without tag 063ba47d7 Update docs for --platform in podman-build.1 0f87cfd28 podman generate kube should not include images command da67c7199 Also show the (initial) disk size 2c5382ba9 Show cpus and memory in machine list 57c055f61 Ignore mount errors except ErrContainerUnknown when cleaningup container 8084c5ef2 Allow machine options to be set from containers.conf c0efa0dba Vendor in containers/buildah v1.23.1 6c7445d2b Vendor in containers/common v0.44.2 d6f6767a5 Set context dir for play kube build f2c676e99 [3.4] podman save: enforce signature removal 8ee18bde1 Use a new markdown converter for sphinx 9dd75d311 Bump to v3.4.0-dev e343b5368 Bump to v3.4.0-rc2 5bc648762 Release notes for v3.4.0-RC2 72e19cf51 Generate kube should'd add podman default environment vars 909cbfe21 sync container state before reading the healthcheck 897150946 Eighty-six eighty-eighty e06abee1d vendor c/[email protected] d45cbbda3 Add a backoff and retries to retrieving exited event 70da2e858 [CI:DOCS] Add network alias note in man pages a98e0371e Remove references to kube being development 70a428662 Support --format tables in ps output 45f8b01f6 Add podman image/container inspect man pages 863ea75c4 compat API: /images/json prefix image id with sha256 c66db2b70 [CI:DOCS] Add link to skopeo delete in podman rmi 7bfe9ca3d remote untag: support digests 7e6921170 System tests: cleanup, and remove obsolete skips 8784c1dd6 Remove unused code from libpod 79966def8 [CI:DOCS] markdown cleanup be15a01c5 Only add 127.0.0.1 entry to /etc/hosts with --net=none d27fcbdc2 container runlabel remove image tag from name 1a25a90a4 Fix /auth compat endpoint c8fd65ea6 fix inverted condition 3bd3c6213 Fix machine image 331ce0f7e utils: return error message from StartTransientUnit 046fa2740 utils: raise warning only on cgroupv2 6001cd02a test/apiv2: set main version back to 3 4406ebb46 [3.4] vendor c/[email protected] 40eeb7d3b runtime: move pause process to scope e6fe5d631 system: move MovePauseProcessToScope to utils ae5a5b51b system: always move pause process when running on systemd 34c9ce2ec system: avoid reading pause pid file 41cd360dc Bump to v3.4.0-dev bd47b9eff Bump to v3.4.0-rc1 29edeaa89 Fix buildah-bud tests by using main's diff file 66eb69224 Fix podman-build manpages by using version from main a647e1d18 Fix release notes 0d43151c2 Remove Pod CPU tests fd56c8386 Set DEST_BRANCH in cirrus to fix CI 4841ec5c6 Final release notes for v3.4.0 RC1 5532cd488 libpod: honor --cgroups=split also with pods e07dccc3a build: take advantage of --platform lists c7c4cb886 build.bats: fix copy tests after containers/buildah#3486 c407813d6 build: mirror --authfile to filesystem if pointing to FD instead of file 69e327378 Bump to Buildah v1.23.0 331d4c5c7 Further release notes updates 901cf71a6 Show variant and codename of the distribution 507000a30 api: handle nil pointer dereference in rest endpoints 702e524ff Fix example in podman machine init man page c8cbd87fd Document `all` query parameter for /libpod/images/prune 939db105c tests: enable --cgroups=disabled test for rootless e0881fd5e tests: simplify --cgroups=disabled test 74bc365eb Enhance bindings for IDE hints e37883f13 Cirrus: NM/CNI workaround + Remove prior-Ubuntu 0ca62196a libpod: rootful close binded ports b6789c3d5 fix restart always with rootlessport ffc8e57d3 remove rootlessport socket to prevent EADDRINUSE fd8d332a4 test: enable --cgroup-parent test 33591c3ef Search gvproxy with config.FindHelperBinary() 1af0f8934 Add deprecated fields for 1.22+ clients that still expect them c6e4453f6 If container exits with 125 podman should exit with 125 5829d62ea Use default username for podman machine ssh c487389fa bump c/common to v0.44.0 069d90124 Initial release notes for v3.4.0 RC1 3c24d1fda Remove pod create options `--cpus` and `--cpuset-cpus` fceec6972 Use new aarch64 fcos repos 31604b43d Revert "logs: adjust handling around partial log messages" c23f81fab Fix #11444: remote breaks with stdout redirection a8875faca [CI:DOCS] Remove short 'a' option from all-tags eec59cea2 Bump github.com/containers/storage from 1.35.0 to 1.36.0 deaf96924 Refacter API server emphasis on logging 4fbc5b8fe Stop outputting 'healthy' on healthcheck 81751bebc Bump github.com/opencontainers/selinux from 1.8.4 to 1.8.5 f5e4ffb5e Add init containers to generate and play kube d2e10a71d podman unshare keep exit code 309d98971 Bump github.com/containers/psgo from 1.5.2 to 1.6.0 f87f27ddc Add /containers/stats response to API docs 8d638d502 try to create the runroot before we warn that it is not writable 5bf220144 machine: set filemodes in octal 6f36a47ac podman machine: enforce a single search registry 50688da29 stats: detect containers restart 2b85382ca api: correctly set the container stats 53dc99fa6 stats: allow to read stats for paused containers a4cc32c2c Fix missing args in name in example 5fdd0431b Cirrus: Run unit-tests rootless 4ccb4f81f Add a system test to modify and import an exported container. c65b43a0f Bump github.com/godbus/dbus/v5 from 5.0.4 to 5.0.5 7cf22279d Fix conmon attach socket buffer size e5468d404 test/e2e/search_test.go - relax tests 78c5a47fc vendor [email protected] 6888b061d inspect: printTmpl must Flush writer 4d9dcab0c podman upgrade tests for networking bbdaf837b Normalize auth key before calling `SetAuthentication` 2f967b81c Add logDriver to podman info ab272d1e9 Add 'Machine %q started' message when podman machine start successful cee689af1 Fix spacing on --userns options in docs 1ff797e36 system tests: new random_free_port helper a1cab358c fix play kube can't use infra_image in config file 6aa666a27 container inspect: improve error handling aa412ccc4 test/testvol/main.go: Fix missing arguments to Errorf() f18ccbcc0 fix play kube --network options 748c2700b pkg/bindings/images.nTar(): set ownership of build context to 0:0 bfcd83ecd Add Checkpointed bool to Inspect 0d1ba0a58 Remove changelog.txt from the repository 8b4f99ac2 QEMU Apple Silicon: Find BIOS FD wherever 1150d1b0b Document default timeout for libpod API Container Restart d1573b95e generate systemd: handle --restart 1eaa44959 logs -f: file: fix dead lock 3d02cfb5e network create: add warning for deprecated macvlan flag bd6403927 cgroup-info: check if user.slice is valid before accessing value 57133bb33 Fix warning of unsupported feature on MacOS c01f7725a TCG Accel fallback for Apple Silicon. Iss #10577 ebd37ede9 Example says there is not IP then in the next command suggests to use it 11fc0e554 kube: Add support for podman pod logs ce5baa125 feat: add localhost into hosts if the networking mode is not host e151f4c9f Fix #11418 - Default TMPDIR to /tmp on OS X 5d31c4250 Bump release to 3.3.1 274a3bc80 Remove unused stubs intended to start a machine with libvirt 8d9e19b03 Spell "build linux darwin" as "build !windows". d346e6e73 Add filtering functionality to http api secrets list 90998176d machine: always check error of net.Dial, even after last try 02a0d4b7f auto-update systemd test: skip on RHEL b3bb7da72 [#11408] podman help machine init cba114dd3 manifest: rm should not remove referenced images. a077335ce make podman run --systemd case insensitive ddeaaa47c Drop dependency on iproute e3c7e02a0 System tests: add cleanup & debugging output abdedc31a rootlessport: allow socket paths with more than 108 chars a55f595fe podman stop always cleanup f9a689f3e generate systemd: clarify limitations of `--new` 1ed0a7209 Cirrus: Reduce APIv2 task timeout 1fb07c422 Make secret env var available to exec session d674eb41e [CI:DOCS] podman cp: highlight globbing and multi-file copy 10144b707 pass LISTEN_* environment into container 9f7bad7da Use UNMERGED vbauerster/mpb PR to fix a pull deadlock b3aee22bd Cirrus: Skip APIv2 tests for [CI:DOCS] 375c3a7b3 docs: fix indentation for userns modes 1122c66ce upgrade test: add new baseline a2a166345 clean up socket and pid files from podman machine 06f94dd09 rootless cni: resolve absolute symlinks correctly ec1f350ee container: resolve workdir after all the mounts happen. de3920c0e auto-update: fix authfile label 9b7ef3dad runtime: Warn if XDG_RUNTIME_DIR is set but is not writable. a5adc3d80 Add support for mount options to API db60a1e65 Add support for libsubid 846941704 Globally replace http:// with https:// ab6c43f3e Shell completion for --format with anonymous fields d28e85741 InfraContainer Rework 1e6d1e5c6 Add filter params description to volume list/prune docs f5ce02b22 Bump github.com/containers/image/v5 from 5.15.2 to 5.16.0 d5507704e volumes: Add volume import to allow importing contents on tar into volume e88b62b34 Fix swagger issue c6e12a2e4 Bump github.com/fsnotify/fsnotify from 1.4.9 to 1.5.1 1dc6d1473 Fix file descriptor leaks and add test 1e176923b teardown play kube 3f22e5296 Allow setting of machine stream and image path from containers.conf 274d6fa19 generate systemd: use --cidfile again 4b2dc48d0 podman inspect show exposed ports 74ab2aaf9 Revert "generate systemd: custom stop signal" c0b1edd6a Network interface 70801b3d7 generate systemd: custom stop signal 3007bd4a9 130-kill.bats: increase timeouts from 10s to 60s 21f396de6 logs: adjust handling around partial log messages b20a54705 330-corrupt-images: don't try to tag with a canonical name fc6a02033 bump github.com/containers/common 1411fa5f2 libpod/Container.readFromJournal(): don't skip the first entry 6b06e9b77 Switch eventlogger to journald by default 02e59c668 utils.RunUnderSystemdScope(): always close Conn d06d285e6 logFile until flag issue edddfe8c4 volumes: Add support for exporting volumes to external tar d24a5d9fd Bump github.com/opencontainers/runc from 1.0.1 to 1.0.2 7b54a5fbe profiling: higher memory sampling rate fe4dc452e Bump github.com/containers/buildah from 1.22.0 to 1.22.3 1493b86c7 Bump github.com/onsi/gomega from 1.15.0 to 1.16.0 feff0d3c4 Use pod netns with --pod-id-file 57a0ed182 Bump k8s.io/api from 0.22.0 to 0.22.1 319c85e89 Support for --tls-verify flag in podman run & podman create e5d8defc4 Update README for 3.3.0 release 33fee83de add flag to record memory profiles db7eaa98b Bump k8s.io/apimachinery from 0.22.0 to 0.22.1 c22f3e8b4 Implement SD-NOTIFY proxy in conmon 7f3f792e2 Fix network aliases with network id fd32c73e3 Update /version endpoint to add components 745f6d949 e2e tests: fix overlay: Unknown option vfs.imagestore 16dfce486 Podman info output plugin information 0897946f6 [NO TESTS NEEDED] Clean up swagger b19812b5a machine: compute sha256 as we read the image file 043457192 machine: check for file exists instead of listing directory 82bb999e3 Bump github.com/containers/image/v5 from 5.15.1 to 5.15.2 2d0a0c0d2 fix rootlessport flake 592fae422 Volumes: Only remove from DB if plugin removal succeeds 9dd088e55 Cirrus: Confirm CGv1 / CGv2 VM expectations 5c837fe5b Skip stats test in CGv1 container environments dc7038288 Fix AVC denials in tests of volume mounts 77f665200 Restore buildah-bud test requiring new images 14f3658da Revert ".cirrus.yml: use fresh images for all VMs" aeffdb05d pkg/bindings/images.nTar(): slashify hdr.Name values cd40c875a Add ability to build images in play kube f0247df89 Bump github.com/rootless-containers/rootlesskit from 0.14.4 to 0.14.5 970529b6a Documented ways to fix firewall rules that are lost when firewalld reloads c1b7787a2 Bump github.com/containers/image/v5 from 5.15.0 to 5.15.1 bfc936261 Cirrus: Resolve two upgrade-test FIXMEs 1f632f357 fix: unifiedOverlays should be assigned if no conflicts found. e9f4d8179 Bump github.com/containers/storage from 1.34.0 to 1.34.1 e7ee15f8c cgroup-manager-systemd:Fail early if user:rootless and relevent session is not present. 3cee85531 libpod/option.go remove error stutter from wrap/wraf fe2be7f88 make sure that signal buffers are sufficiently big f98569946 volume: move validating volume dest from client to server. 91e21bed4 rootful: unset XDG_RUNTIME_DIR 2a8c41448 Fix rootless cni dns without systemd stub resolver 257d5e8a7 Fixed healthcheck default values when container created via compat API d99756434 Add space trimming check in ValidateSysctls bef26f258 rename oneshot initcontainers to once 9fc946563 Set gvproxy path to /usr/libexec/podman/gvproxy 5a32946d6 For compatibility, ignore Content-Type 404488a08 Run codespell to fix spelling 643178c1e Revert "Use static path for gvproxy" 73a755eec Fix device tests using ls test files d0e3b3c3a Enhance priv. dev. check cfbbc38a5 Workaround host availability of /dev/kvm 2e3ba9cd9 Change connection error to be helpful for machine users ed30ae4a8 Add until filter to podman pod ps 800a65fb2 [CI:DOCS] Fix multi-arch image docs 4e4c4b62f Bump github.com/opencontainers/selinux from 1.8.3 to 1.8.4 af46a64a8 Document source ip for the rootlesskit port handler f7de8bc80 Bump github.com/containers/storage from 1.33.1 to 1.34.0 8b9b925e7 skip flaking auto-update test 27443660c Enable docker-py compat. testing w/ ignored result 221b1add7 Add support for pod inside of user namespace. 12ac4198c Libpod images pull changes e7b7c90ba Reproducible Builds: trim embedded cgo paths 170fb2572 Alias build to buildx, so it won't fail bb96da9f1 Skip cgroup-parent test due to frequent flakes a4bdc67c4 Added autocompletion for images and system connections 1adeb2b70 podman info show correct slirp4netns path 79e4baf4c Bump github.com/onsi/gomega from 1.14.0 to 1.15.0 541e83ffe personality: Add support for setting execution domain. 88b9cbd5e Bump k8s.io/api from 0.21.3 to 0.22.0 e52187e7f show podman machine ssh command line 30df551bd auto-update: simple rollback adee0ca59 Bump github.com/BurntSushi/toml from 0.3.1 to 0.4.1 eb2e99101 Bump k8s.io/apimachinery from 0.21.3 to 0.22.0 c9e2f2f60 [CI:DOCS] tests-expect-exit: include source line numbers 8cbbbe6ef Fix TS parsing for fractional values 3c3fa6fac implement init containers in podman f4dd22b31 Cirrus: Fix not uploading logformatter html ddc360fe1 Bump Buildah to v1.22.0 [NO TESTS NEEDED] 41f94a4dc Fix podman unpause,pause,kill --all to work like podman stop --all cfcd1e186 Do not add an entry to /etc/hosts with `--net=host` f40a0e7c8 Handle timezone on server containers.conf e78f3e8c4 Bump github.com/docker/docker bd29ec4c3 Bump github.com/rootless-containers/rootlesskit from 0.14.3 to 0.14.4 9cc974c96 Only support containers stats using cgroups v2 ecf103302 podman info: try qfile before equery cc43b5133 image scp: fix typo in output e88d8dbea fix rootless port forwarding with network dis-/connect 4acc1d685 Use static path for gvproxy a210a2292 Compat API: Fix healthcheck status and healthcheck config 0762c7e97 Bump github.com/opencontainers/selinux from 1.8.2 to 1.8.3 985c71708 Fix handling of user specified container labels 03ffba29a podman-registry: minor usability updates 0ab9d19ad Bump to v4.0.0-dev 34b28d959 e2e tests: re-enable and fix podman stats tests c0952c733 Support size and inode options on builtin volumes 1d10ca739 Created scp.go image_scp_test.go and podman-image-scp.1.md 8ccf2539e test: move container process to a sub-cgroup cdbbd7915 stats: add a interval parameter to cli and api stream mode Signed-off-by: Bruce Ashfield <[email protected]>

Aditya Rajan (7): manifest: rm should not remove referenced images. kube: Add support for podman pod logs cgroup-info: check if user.slice is valid before accessing value inspect: printTmpl must Flush writer build: mirror --authfile to filesystem if pointing to FD instead of file build.bats: fix copy tests after containers/buildah#3486 stop: Do nothing if container was never created in runtime Alex Jia (1): e2e tests: fix overlay: Unknown option vfs.imagestore Anders F Björklund (3): Show variant and codename of the distribution Show cpus and memory in machine list Also show the (initial) disk size Anton Tykhyy (1): Fix #11444: remote breaks with stdout redirection Ashley Cui (9): Change connection error to be helpful for machine users Allow setting of machine stream and image path from containers.conf Make secret env var available to exec session Use default username for podman machine ssh Fix machine image Vendor in containers/common v0.44.2 Vendor in containers/buildah v1.23.1 Allow machine options to be set from containers.conf Remind user to check connection or use podman machine Brent Baude (12): Use static path for gvproxy implement init containers in podman show podman machine ssh command line Revert "Use static path for gvproxy" Set gvproxy path to /usr/libexec/podman/gvproxy rename oneshot initcontainers to once Add ability to build images in play kube teardown play kube clean up socket and pid files from podman machine Remove references to kube being development Set context dir for play kube build Support selinux options with bind mounts play/gen Chen Zhiwei (1): fix play kube can't use infra_image in config file Chris Evich (17): Cirrus: Fix not uploading logformatter html Skip cgroup-parent test due to frequent flakes Enable docker-py compat. testing w/ ignored result [CI:DOCS] Fix multi-arch image docs Workaround host availability of /dev/kvm Enhance priv. dev. check Fix device tests using ls test files Cirrus: Resolve two upgrade-test FIXMEs Revert ".cirrus.yml: use fresh images for all VMs" Restore buildah-bud test requiring new images Fix AVC denials in tests of volume mounts Skip stats test in CGv1 container environments Cirrus: Confirm CGv1 / CGv2 VM expectations Cirrus: Skip APIv2 tests for [CI:DOCS] Cirrus: Reduce APIv2 task timeout Cirrus: Run unit-tests rootless Cirrus: NM/CNI workaround + Remove prior-Ubuntu Daniel J Walsh (21): Support size and inode options on builtin volumes Fix handling of user specified container labels Handle timezone on server containers.conf Fix podman unpause,pause,kill --all to work like podman stop --all Alias build to buildx, so it won't fail Add support for pod inside of user namespace. Run codespell to fix spelling Implement SD-NOTIFY proxy in conmon Switch eventlogger to journald by default Globally replace http:// with https:// Add support for libsubid Fix spacing on --userns options in docs Add 'Machine %q started' message when podman machine start successful Add logDriver to podman info Stop outputting 'healthy' on healthcheck If container exits with 125 podman should exit with 125 Add podman image/container inspect man pages Generate kube should'd add podman default environment vars Ignore mount errors except ErrContainerUnknown when cleaningup container podman generate kube should not include images command Fix english on prune prompt Ed Santiago (11): podman-registry: minor usability updates podman info: try qfile before equery [CI:DOCS] tests-expect-exit: include source line numbers upgrade test: add new baseline System tests: add cleanup & debugging output auto-update systemd test: skip on RHEL system tests: new random_free_port helper [CI:DOCS] markdown cleanup System tests: cleanup, and remove obsolete skips Eighty-six eighty-eighty System tests: speed up. They've gotten too slow. Fabien Benetou (1): Example says there is not IP then in the next command suggests to use it Giuseppe Scrivano (15): test: move container process to a sub-cgroup docs: fix indentation for userns modes stats: allow to read stats for paused containers api: correctly set the container stats stats: detect containers restart test: enable --cgroup-parent test tests: simplify --cgroups=disabled test tests: enable --cgroups=disabled test for rootless libpod: honor --cgroups=split also with pods system: avoid reading pause pid file system: always move pause process when running on systemd system: move MovePauseProcessToScope to utils runtime: move pause process to scope utils: raise warning only on cgroupv2 utils: return error message from StartTransientUnit Guillaume Rose (3): machine: check for file exists instead of listing directory machine: compute sha256 as we read the image file machine: always check error of net.Dial, even after last try Hyeon Kim (1): Search gvproxy with config.FindHelperBinary() Jakub Guzik (3): Add until filter to podman pod ps Add filter params description to volume list/prune docs Add filtering functionality to http api secrets list Jason T. Greene (2): Add deprecated fields for 1.22+ clients that still expect them Disable docker and alias to podman in FCOS ignition Jelle van der Waa (4): Document default timeout for libpod API Container Restart Add /containers/stats response to API docs Document `all` query parameter for /libpod/images/prune api: handle nil pointer dereference in rest endpoints Jhon Honce (10): Only support containers stats using cgroups v2 For compatibility, ignore Content-Type [NO TESTS NEEDED] Clean up swagger Update /version endpoint to add components Fix file descriptor leaks and add test Fix swagger issue Add support for mount options to API Refacter API server emphasis on logging Enhance bindings for IDE hints Support --format tables in ps output Jonathan Springer (2): TCG Accel fallback for Apple Silicon. Iss #10577 QEMU Apple Silicon: Find BIOS FD wherever Matej Vasek (3): Fix TS parsing for fractional values fix inverted condition Fix /auth compat endpoint Matthew Heon (26): Bump to v4.0.0-dev Do not add an entry to /etc/hosts with `--net=host` Volumes: Only remove from DB if plugin removal succeeds Update README for 3.3.0 release Add Checkpointed bool to Inspect Remove pod create options `--cpus` and `--cpuset-cpus` Initial release notes for v3.4.0 RC1 Further release notes updates Bump to Buildah v1.23.0 Final release notes for v3.4.0 RC1 Set DEST_BRANCH in cirrus to fix CI Remove Pod CPU tests Fix release notes Fix podman-build manpages by using version from main Fix buildah-bud tests by using main's diff file Bump to v3.4.0-rc1 Bump to v3.4.0-dev Add a backoff and retries to retrieving exited event Release notes for v3.4.0-RC2 Bump to v3.4.0-rc2 Bump to v3.4.0-dev Ensure pod ID bucket is properly updated on rename Release notes for v3.4.0 final release Fix release notes Final release notes update for v3.4.0 Bump to v3.4.0 Maya Rashish (2): Spell "build linux darwin" as "build !windows". Remove unused stubs intended to start a machine with libvirt Michael Anckaert (1): Fix #11418 - Default TMPDIR to /tmp on OS X Milivoje Legenovic (2): Compat API: Fix healthcheck status and healthcheck config Fixed healthcheck default values when container created via compat API Miloslav Trmač (1): Use UNMERGED vbauerster/mpb PR to fix a pull deadlock Nalin Dahyabhai (11): pkg/bindings/images.nTar(): slashify hdr.Name values utils.RunUnderSystemdScope(): always close Conn libpod/Container.readFromJournal(): don't skip the first entry bump github.com/containers/common 330-corrupt-images: don't try to tag with a canonical name logs: adjust handling around partial log messages 130-kill.bats: increase timeouts from 10s to 60s pkg/bindings/images.nTar(): set ownership of build context to 0:0 build: take advantage of --platform lists Update docs for --platform in podman-build.1 remote build: EvalSymlinks() the context directory Parham Alvani (1): feat: add localhost into hosts if the networking mode is not host Paul Holzinger (40): fix rootless port forwarding with network dis-/connect podman info show correct slirp4netns path skip flaking auto-update test Document source ip for the rootlesskit port handler Fix rootless cni dns without systemd stub resolver rootful: unset XDG_RUNTIME_DIR fix rootlessport flake Podman info output plugin information Fix network aliases with network id Use pod netns with --pod-id-file Network interface podman inspect show exposed ports Shell completion for --format with anonymous fields rootless cni: resolve absolute symlinks correctly podman stop always cleanup rootlessport: allow socket paths with more than 108 chars Drop dependency on iproute make podman run --systemd case insensitive network create: add warning for deprecated macvlan flag fix play kube --network options podman upgrade tests for networking Fix conmon attach socket buffer size try to create the runroot before we warn that it is not writable podman unshare keep exit code Revert "logs: adjust handling around partial log messages" bump c/common to v0.44.0 remove rootlessport socket to prevent EADDRINUSE fix restart always with rootlessport libpod: rootful close binded ports Fix example in podman machine init man page container runlabel remove image tag from name Only add 127.0.0.1 entry to /etc/hosts with --net=none Remove unused code from libpod compat API: /images/json prefix image id with sha256 sync container state before reading the healthcheck Use a new markdown converter for sphinx shell completion: do not show images without tag Revert "rootful: unset XDG_RUNTIME_DIR" rootful: do not set XDG_RUNTIME_DIR for cni plugins podman machine: do not join userns Raoul Bhatia (1): test/testvol/main.go: Fix missing arguments to Errorf() Sankalp Rangare (1): added healthcheck to ps command Sascha Grunert (1): Normalize auth key before calling `SetAuthentication` Scott Schreckengaust (1): Fix warning of unsupported feature on MacOS Shion Tanaka (1): Fix missing args in name in example Shivkumar13 (1): Support for --tls-verify flag in podman run & podman create Thomas Weber (2): stats: add a interval parameter to cli and api stream mode e2e tests: re-enable and fix podman stats tests TomSweeneyRedHat (3): Bump Buildah to v1.22.0 [NO TESTS NEEDED] [CI:DOCS] Remove short 'a' option from all-tags [CI:DOCS] Add network alias note in man pages Tsubasa Watanabe (1): Add a system test to modify and import an exported container. Urvashi Mohnani (3): Add init containers to generate and play kube [CI:DOCS] Add link to skopeo delete in podman rmi [NO TESTS NEEDED] Add port configuration to first regular container Valentin Rothberg (26): image scp: fix typo in output auto-update: simple rollback make sure that signal buffers are sufficiently big add flag to record memory profiles profiling: higher memory sampling rate generate systemd: custom stop signal Revert "generate systemd: custom stop signal" generate systemd: use --cidfile again auto-update: fix authfile label pass LISTEN_* environment into container [CI:DOCS] podman cp: highlight globbing and multi-file copy generate systemd: clarify limitations of `--new` logs -f: file: fix dead lock generate systemd: handle --restart container inspect: improve error handling vendor [email protected] test/e2e/search_test.go - relax tests podman machine: enforce a single search registry machine: set filemodes in octal [3.4] vendor c/[email protected] test/apiv2: set main version back to 3 remote untag: support digests vendor c/[email protected] [3.4] podman save: enforce signature removal [CI:DOCS] cmd/podman: no dot for short descriptions libpod: do not call (*container).Config() afro-coder (1): Documented ways to fix firewall rules that are lost when firewalld reloads baude (1): Use new aarch64 fcos repos cdoern (5): Created scp.go image_scp_test.go and podman-image-scp.1.md Added autocompletion for images and system connections Libpod images pull changes logFile until flag issue InfraContainer Rework dependabot[bot] (24): Bump github.com/opencontainers/selinux from 1.8.2 to 1.8.3 Bump github.com/rootless-containers/rootlesskit from 0.14.3 to 0.14.4 Bump github.com/docker/docker Bump k8s.io/apimachinery from 0.21.3 to 0.22.0 Bump github.com/BurntSushi/toml from 0.3.1 to 0.4.1 Bump k8s.io/api from 0.21.3 to 0.22.0 Bump github.com/onsi/gomega from 1.14.0 to 1.15.0 Bump github.com/containers/storage from 1.33.1 to 1.34.0 Bump github.com/opencontainers/selinux from 1.8.3 to 1.8.4 Bump github.com/containers/storage from 1.34.0 to 1.34.1 Bump github.com/containers/image/v5 from 5.15.0 to 5.15.1 Bump github.com/rootless-containers/rootlesskit from 0.14.4 to 0.14.5 Bump github.com/containers/image/v5 from 5.15.1 to 5.15.2 Bump k8s.io/apimachinery from 0.22.0 to 0.22.1 Bump k8s.io/api from 0.22.0 to 0.22.1 Bump github.com/onsi/gomega from 1.15.0 to 1.16.0 Bump github.com/containers/buildah from 1.22.0 to 1.22.3 Bump github.com/opencontainers/runc from 1.0.1 to 1.0.2 Bump github.com/fsnotify/fsnotify from 1.4.9 to 1.5.1 Bump github.com/containers/image/v5 from 5.15.2 to 5.16.0 Bump github.com/godbus/dbus/v5 from 5.0.4 to 5.0.5 Bump github.com/containers/psgo from 1.5.2 to 1.6.0 Bump github.com/opencontainers/selinux from 1.8.4 to 1.8.5 Bump github.com/containers/storage from 1.35.0 to 1.36.0 flouthoc (9): personality: Add support for setting execution domain. volume: move validating volume dest from client to server. libpod/option.go remove error stutter from wrap/wraf cgroup-manager-systemd:Fail early if user:rootless and relevent session is not present. fix: unifiedOverlays should be assigned if no conflicts found. volumes: Add support for exporting volumes to external tar volumes: Add volume import to allow importing contents on tar into volume runtime: Warn if XDG_RUNTIME_DIR is set but is not writable. container: resolve workdir after all the mounts happen. jesperpedersen (3): [#11408] podman help machine init Bump release to 3.3.1 Remove changelog.txt from the repository kpcyrd (1): Reproducible Builds: trim embedded cgo paths xatier (1): Add space trimming check in ValidateSysctls

Podman now installs the systemd service and socket by default, so we can drop our custom installation of those elements, otherwise the build is unchanged. Bumping libpod to version v4.0.1-11-g717edd7b8, which comprises the following commits: 0f626c377 Bump to v4.0.3-dev 342c82593 Bump to v4.0.2 bd5ff1c32 Update release notes for v4.0.2 791c8c347 Revert "use GetRuntimeDir() from c/common" cc4a70c80 Revert "Option --url and --connection should imply --remote." ca980c2e0 Option --url and --connection should imply --remote. cfcc0d639 Bump to v4.0.2-dev c8b9a2e3e Bump to v4.0.1 b1ffa822f Update release notes for v4.0.1 de9f22805 Fix a potential flake in volume plugins tests 697dd2890 Propagate $CONTAINERS_CONF to conmon c559e4e6f tests: Remove inaccurate comment 3718d096b System tests: show one-line config overview e1d5c812d provide better error on invalid flag 2b85f62a2 use GetRuntimeDir() from c/common 82f4760de kube: honor --build=false and make --build=true by default e356dfe06 system tests: cleanup networks on teardown 71b0909f2 Remove the runtime lock ee7cf3cc2 Don't log errors on removing volumes inuse, if container --volumes-from eb9fe52a5 kube: honor mount propagation mode a0c34d64a Load ip_tables modules at boot e8d7e580a Cirrus: Disable F34 aka prior-fedora testing 7b106f5b6 Cirrus: Update VM Images for 4.0 release d59749d64 Bump to v4.0.1-dev 49f8da727 Bump to v4.0.0 84c8870ac Release notes for v4.0.0 final 15cb91855 Fix lint ae9ad416a Fix manifest 4.0 Endpoints Branch forced 4.0 only endpoints 1a8c715f1 Introduce podman machine init --root=t|f and podman machine set --root=t|f f71dfcb5d Initial implementation of mac forwarding using a privileged docker sock claim helper 2128236da ignition: propagate proxy settings from a host into a vm 809da6b0b Update to podman4 copr stream bd8ac0017 Unify ls --filter docs for networks and pods 77e51e188 e2e: merge after/since image-filter tests 8ad29421e podman network: add documentation for netavark f35e03ec8 create: Fix key=value annotation in the flag output 22cfa9860 enable netavark specific tests d77b4f92c Fix checkpoint/restore pod tests a72e22160 Make sure building with relative paths work correctly. 975d79aed Add 409 response to swagger godoc 421b7466c Fix images since/after tests 04badc2c9 Changes of docker descriptions 09708bee9 Fix images since/after tests 35a4f32be Changes of docker descriptions 629d86445 Temporarily pull machine images from side repo a6fbfd47c Cirrus: TODO: netavark/aardvark release branches e5644bbf1 Cirrus: Expand netavark testing to include rootless 1656a2335 Cirrus: Minor - limit release task applicability afb39f2e4 Cirrus: Add [CI:BUILD] magic that only builds 926c3b08a CI: fix nightly builds 1e3115cf4 Cirrus: Log netavark/aardvark binary build info. 66a3be370 Cirrus: Add netavark/aardvark system test task 6b0d4d915 Cirrus: Also download aardvark-dns binary b63f61f5c Cirrus: Add e2e task w/ upstream netavark 6a3de9351 Revert minimum API change 9688a462e netavark e2e tests 92790e98c Bump to v4.0.0-dev d7d79ce81 Bump to v4.0.0-RC5 5356e36b8 Update release notes for v4.0.0-RC5 77ca2498e Modify /etc/resolv.conf when connecting/disconnecting f8cd4df1b Do not set the network config dir to cni plugin dir d0fccbbbb Show API doc for several versions e7998b122 [NO NEW TEST NEEDED] Add schema for ImageCreate 200 response. 6d01b6dd6 fix: Multiplication of durations ed60f8908 move rootless netns slirp4netns process to systemd user.slice 7e37c608f compat: endpoint /build must set header content type as application/json in reponse 9aee36b76 Cleanup: remove obsolete/misleading bug workaround b1b9a0d7a tests: retrofit healthcheck system tests 74cba33c7 healthcheck, libpod: Read healthcheck event output from os pipe 7ec63f092 Fix: Do not print error when parsing journald log fails d62a0204d Bump github.com/buger/goterm from 1.0.1 to 1.0.4 bcd5f5ead append podman dns search domain b1bf91a22 Podman pod create --share-parent vs --share=cgroup 85c0fe7dc System tests: revert emergency skip of checkpoint tests 71d151449 Add version guard to libpod API endpoints 345413540 [v4.0] Bump c/common to v0.47.4 7499496f3 idmap should be able to be specified along with other options e47a3bec9 Vendor in containers/buildah v1.24.1 cad3eb78b Bump to v4.0.0-dev 0c9648136 Bump to v4.0.0-RC4 c1618042f Disable failing E2E test 70623790d Revert "Move each search dns to its own line" 48f10e1d0 Move each search dns to its own line 938d5152c Update release notes for v4.0.0-RC4 99968002f Document `schema` values in the `--url` flag 6d747dca2 podman image scp syntax correction e0cbcdc33 system prune: remove all networks 8f3f0710f Only change network fields if they were actually changed by the user fb6fca806 docs: clarify rootless net stats cad6459b6 Fix size to match Docker selection 06821627f libpod: enforce noexec,nosuid,nodev for /dev/shm 44cd232be Clarify remote client means Mac and Windows 9d3bcb587 libpod: report slirp4netns network stats f65b62c98 Add notes to "--oom-kill-disable" not supported on cgroups V2 178cccbf9 Fix use of infra image to clarify default 97c8bdfeb Adapt podman images ls filters docs to be aligned with prune filters docs 49076ba87 ignition, machine: delegate cpu,io cgroup controllers to machine's default users 0c9a8ac07 pkg/bindings/images.Build(): slashify "dockerfile" values, too 3b565bacf Remove mention of IPv6 portfwd from release notes 10a966a2a Bump to v4.0.0-dev 9b441c0dd Bump to v4.0.0-RC3 f5dfe026d Update release notes for v4.0.0-RC3 ebf5ad50e Fix Cirrus destination branch e64e6500d volume: add support for non-volatile upperdir,workdir for overlay volumes a928d39d0 github: label issues based on os fix regex 525bdc377 github: label issues based on os 4c26a3a5c Cirrus: Fix get_ci_vm.sh initial setup d455bb879 System tests: emergency skip of checkpoint tests 6961d9120 network create: allow multiple subnets 86547cc24 Update troubleshooting.md 24dc02064 Fix sort ordering of filters 63b1557a2 Unify podman prune filter description: volumes, networks, system 4a4d86d40 Bump Buildah to v1.24.0 6336e1ff1 rootless: drop permission check for devices 77cd38d40 switch podman image scp from depending on machinectl to just os/exec ab22a688d Bump github.com/containers/image/v5 from 5.18.0 to 5.19.0 991652988 Bump github.com/containers/storage from 1.38.0 to 1.38.1 9073b56a3 change location of where make outputs podman binary on osx 72ddacdbe Github workflow: Fix parsing of GraphQL response JSON 6df245c6e Github-workflow: Fix YAML syntax 44a87229b Update godoc, swagger using wrong struct e4636ebdc Makefile: install targets independent of build 42e1c2981 [CI:DOCS] Fix typos and improve language 7cdb00a45 CI: enable rootless-remote system tests 98739237e pkg/specgen/generate/security: fix error message 29e89da1a Github workflow: Send e-mail on job error 0d42d9f8d Github workflow: Update Cirrus-cron GraphQL query dbfe79757 remote build: set rootless oci isolation correctly 8099a61b6 [CI:DOCS] Fix typos and improve language 80a5295d4 Fix handling of duplicate matches on id expansion 1cddd6397 Show correct default values or show none e252b3b4f exec: retry rm -rf on ENOTEMPTY and EBUSY 2f371cb12 container create: do not check for network dns support 75e6994d4 libpod: fix leaking fd f6e36a649 libpod: fix connection leak e68d188f6 [CI:DOCS] fix typo subpordinate aff6a5af8 Fix filter description and unify filters docs for containers/images prune 7938f32c5 Remove unused param and clean API handlers e834297b3 Restore machine start logic that was hanging c81a616ca Bump to v4.0.0-dev 71238d3cc Bump to v4.0.0-RC2 b29640c78 Final release notes for v4.0.0-rc2 5736649eb Run codespell on code f6bb60087 Update release notes for Podman v4.0.0 653da8fe8 Fix #2 for compat commit handling of --changes 9d815707e Fix nil pointer dereference for configmap optional 0b5136c7c Make error message matching in 030-run.bats less fragile 9241b4e34 Don't explicitly check for crun|runc in package information 2947ded7a Don't segfault if an image layer has no creation timestamp 1c0fdba4f compat: remove hardcoded index from load images output report 9df31cfb7 compat: images/load must be able to load tar with multiple images 47df14af5 System tests: fix for new systemd on rawhide ee039b740 Remove rootless_networking option from containers.conf e22b9889d vendor c/[email protected] 1f85244ab Engine.Remote from containers.conf 2c492be00 vendor: bump c/common and other vendors 7046e7804 rootless: report correctly the error 2d0b5ebb5 Implement API forwarding for podman machine on Windows 4693fc6db Implement env parsing on Windows c674d3cc7 Handle changes in docker compat mode dbaaef5c4 Show package version when running on alpine b9a2d8698 Handlers for `generate systemd` with custom dependencies abcd29239 APIv2 tests: followup to recent log test 4b384e08a Add IndexConfigs to compat /info endpoint a0165a64b Bump github.com/opencontainers/runc from 1.0.3 to 1.1.0 af6a43fa4 apiv2 test: add regression test for #12904 4d1c327ed SECURITY.md: fix the project name c0e072346 rename --cni-config-dir to --network-config-dir 7e30531f2 compat attach: fix write on closed channel 774271c38 upgrade all dependencies 38fbc8af1 Revert "Cirrus: Temporarily disable OSX Cross task" 4adf457ff Bump github.com/opencontainers/runc from 1.0.3 to 1.1.0 bd09b7aa7 bump go module to version 4 f23e8ca67 [NO NEW TESTS NEEDED] add builddeps to copr template 471a4356b CI: rootless user: also create in some root tests c8124b88a [WIP] Tests for podman image scp (the sudo form) 141de8686 Revamp Libpod state strings for Docker compat 860463d97 Cirrus: Temporarily disable OSX Cross task 06ad51c83 update c/common to latest 10d969ff1 Use PODMAN_USERNS environment variable when running as a service 6bca61e0f Unify the method of parsing filters in cmd 3c2a5947c fix default branch links d6e55577c [CI:DOCS] fix default branch links bb3097cd0 [CI:DOCS] Unprivileged native overlayfs is now supported ab8a50848 [CI:DOCS] Fix typo in --env 420303b94 Recursively copy cert files. 8a7e70919 Refactor manifest list operations 350765e79 Add rpkg template for COPR autobuild 607cb80bf Fix cgroup mode handling in api server a15dfb364 Standardize on capatalized Cgroups 13917dfab test/system: podman run update /etc/hosts 14940a067 Remove two GetImages functions from API 72ab66d88 Use fully-qualified device name in CDI test 968deb7c2 Use new CDI API 96be2bb3d troubleshooting links to main branch bf3734ad5 Podman Build use absolute filepath 699683010 Prohibit --uid/gid map and --pod for container create/run a4cef5435 podman container rm: remove pod ece768ff9 Manual fixes for PR #12642: 92e787521 podman build enable --all-platforms and --unsetenv fa6405c3c use events_logfile_path from containers.conf for events log. f257d9839 Podman Pod Create --sysctl support b7fe25dc2 Wait for podman stop to complete 194d14ca2 libpod: fix check for systemd session 8dc2464b0 libpod: refine check for empty pod cgroup b24063582 fix buildah-bud test diff 85f9cf390 upgrade test: check that network backend is cni 918890a4d use netns package from c/common 0151e10b6 update buildah to latest and use new network stack 858b21064 podman image scp: implement --quiet 495884b31 use libnetwork from c/common fde6ad637 Add --noout option to prevent the output of ids 5aedcb364 remote events: convert TimeNano properly 47374aac8 Bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0 485305a5f vendor latest c/common 6e208c222 add additional fields to podman machine ls --json 6fa077750 buildah bud tests: skip failing tests 83b0fb469 Fix permission on secrets directory 8f2358eea Add podman rm --depend f04465bfe fix host.containers.internal entry for macvlan networks 6d5ad9c11 It takes some time to start a VM c085fb3c9 Pretty Print output of podman machine ls --format json 19a475906 Use the InfraImage defined in containers.conf 799078216 Cirrus: Freshen VM images 0e4e5cf99 Revert "Cirrus: Temp. ignore gitlab task failures" a95c01e0e pkg: use PROXY_VARS from c/common a8b02cf4b ignition: add support from setting SSL_CERT_FILE 5c363ff27 ignition: propogate HTTP proxy variables from host to remote 18785450e Bump to v4.0.0-dev 9d26c1abb Bump to v4.0.0-RC1 508f9b76e System tests: fix RHEL8 gating tests b7380a7c3 vendor c/common 01ba2531b Remove dead RuntimeOption functions 0933f6c0b Update docker cli message for case where user creates directory 4dc5a5b15 Don't add env if optional and not found a8a3e8bc9 Fix type-o in podman.wxs 37c0b27b6 [CI:DOCS] fixes indentation of example pod yaml 7dada6d49 Prevent double decoding of storage options f68890815 Emergency system-test fixes 1941d45e3 add OCI Runtime name to errors 2a524fcae fix healthcheck timeouts and ut8 coercion 4191616cc Don't rename pod if container has the same name 13f3fd255 Set volume NeedsCopyUp to false iff data was copied up 7a24be6ad Fix CI 680923743 correct typo words in docs 64df41755 Change Tests to ignore missing containers when removing --all 79c5b73ed test/e2e/pod_initcontainers: fix a flake cf7fc3695 test/e2e/run: don't use date +%N on Alpine 2e0d3e9ea Support all volume mounts for rootless containers 32e845028 Fix wrong 'podman search --format' placeholder 0c6ae3ab2 Fix Container List API call to return mount info 76a944b14 fix misleading comment regarding default value of cpu period [NO NEW TESTS NEEDED] c496001d0 add --ip6 flag to podman create/run 116a276e8 legacy events: also set exitCode f6a3eddd2 Don't initialize the global RNG with GinkgoRandomSeed() in e2e tests 90e74e794 Avoid collisions on RemoteSocket paths ee146a9ab Refactor remote socket path determination in tests a8e223faf fix doc 2ff5644bf test/system: podman run image with filesystem permission fc65b0f73 test/system: podman run with log-opt option 1e3434d11 Update swagger documentation 6630e5cf6 Make it possible to select the volume driver a3326e23d Check the mount type for future compatibility 8e7eeaa4d Implement virtfs volumes for podman machine ec32430a0 [CI:DOCS] Add example of cpus to init command a2687783d prefix imageId with sha256: in containers list test for compat API ImageId 289270375 Pod Security Option support f21744939 ignition: add certs from current user into the machine while init 410082f25 docs: sort swagger operations alpabetically 7117d5605 .service file removal on failure 803defbe5 Introduce Windows WSL implementation of podman machine f6d00ea6e podman image scp never enter podman user NS e8c06fac9 Allow users to add host user accounts to /etc/passwd 1aa4e4d4d container creation: don't apply reserved annotations from image cbcab4342 [CI:DOCS] clarify `io.podman.annotations.seccomp` d669dbfb9 Error out early if system does not support pre-copy checkpointing b746b2256 Update go-criu to v5.3.0 cb4f498e4 [CI:DOCS] docs: document rootless userns mappings 3ac5999f8 Switch to a new installer approach using a path manipulation helper 207823eb0 e2e: Add dev/shm checkpoint/restore test f3d485d4d Enable checkpoint/restore for /dev/shm 2d7dbda41 Update github.com/checkpoint-restore/checkpointctl af1dbbfb7 Always run passwd management code when DB value is nil a5e49d966 Warn on use of --kernel-memory 04dbbd96b support hosts without /etc/hosts 20ce6e5c6 Podman run --passwd fca66b6cb ci: force scratch build for crun 64ce6949f Use hosts public ip address in rootless containers b1f5e861b compat: image normalization: handle sha256 prefix 89ee302a9 specgen: honor userns=auto from containers.conf bb096c3bf [CI:DOCS] Small checkpoint/restore man page fixes 1ddb49c66 [CI:DOCS] Explicitly mention that checkpointing systemd containers might fail 3570c38ff vendor: update containers/storage 48cb44651 build: fix test for subid 4 46a094a7a test: add --rm to podman run commands af6bcd086 fix(generate): fix up podman generate kube missing env field bug a1ebde118 legacy events: also set Action="die" a837984c4 rootless: include the args in the debug message 5cbc6b62d apiv2 tests: use quay.io/libpod/testimage:20210610 for platform tests 12d762f8e image rm: allow for force-remove infra images 6423174c6 tests: adjust old build test to expect exit code 28018ce60 Test for checkpoint specific inspect fields bc3389e21 Add more checkpoint/restore information to 'inspect' f566d8b8e build: relay exitcode from imagebuildah to registry e88c21366 Removed .service file for healthchecks a86495ea6 Set machine timezone 459e78414 MovePauseProcessToScope do not seed everytime f241efb17 bindings rmi test: clarify behavior 03a3fc37f bump cobra to 1.3.0 6cde9255f .github: revert to the old template 4243ca93a oci: configure the devices cgroup with default devices 3b6510da6 kill: fix output 5392ff51c e2e: search flake: skip test on registry.redhat.io 7b51acd4c APIv2 tests: fail on syntax/logic errors 51a4bef2e Show --external containers even without --all option 0a2eb7b18 apiv2 tests: refactor complicated curls 888c778ee fix network id handling afdb4dc22 Update Windows Install Doc 52b12fe98 Fixes #12063 Add docker compatible output after image build. 65d5a2b68 pause scope: don't use the global math/rand RNG ef325bc8c specgen: check that networks are only set with bridge 094e1d70d container restore/import: store networks from db 3e9af2029 play kube add support for multiple networks 535818414 support advanced network configuration via cli d072167fe Add new networks format to spegecen 46938bbf8 fix incorrect swagger doc for network dis/connect 4791595b5 network connect allow ip, ipv6 and mac address 9ce6b6413 network db: add new strucutre to container create 4e8ad039c remove unneeded return value from c.Networks() 5490be67b network db rewrite: migrate existing settings 5f1f62f0b network ls: show networks in deterministic order 5a071d9f5 Bump github.com/docker/docker 1fff76c3c pprof flakes: bump timeout to 20 seconds 50501f49a Add secret list --filter to cli 8cb93ac10 Cirrus: Temp. ignore gitlab task failures 81a0a7984 compat build: adhere to q/quiet 5bbcfaf4a Make XRegistryAuthHeader and XRegistryConfigHeader private 3cfefa124 Remove the authfile parameter of MakeXRegistryAuthHeader d79414c54 Simplify the header decision in pkg/bindings/images.Build a bit f9be32627 Remove the authfile parameter of MakeXRegistryConfigHeader 935dcbb00 Remove no-longer-useful name variables 0e29b8975 Consolidate creation of SystemContext with auth.json into a helper fe1230ef7 Remove pkg/auth.Header 3725a34cb Call MakeXRegistryAuthHeader instead of Header(..., XRegistryAuthHeader) 78dd79752 Turn headerAuth into MakeXRegistryAuthHeader d073b1275 Call MakeXRegistryConfigHeader instead of Header(..., XRegistryConfigHeader) 8155fb565 Turn headerConfig into MakeXRegistryConfigHeader 29f408871 Move the auth file creation to GetCredentials 9d56ebb61 Consolidate the error handling path in GetCredentials da86a2328 Only look up HTTP header values once in GetCredentials 1589d70bc Use Header.Values in GetCredentials.has 2946e8349 Beautify GetCredentials.has a bit 1ecc6ba72 Pass a header value directly to parseSingleAuthHeader and parseMultiAuthHeader 6f1a26b04 Simplify parseSingleAuthHeader 7674f2f76 Simplify the interface of parseSingleAuthHeader 2aeb690d3 Don't return a header name from auth.GetCredentials 491951d66 Fix normalizeAuthFileKey to use the correct semantics 1b6bf9713 Rename normalize and a few variables d29a4a6d1 Add TestHeaderGetCredentialsRoundtrip ad7e5e34f Add tests for auth.Header 5a5aa6009 Improve TestAuthConfigsToAuthFile ff003928b Add unit tests for singleAuthHeader b162d8868 Add unit tests for multiAuthHeader bc191ca7d fix e2e test missing network cleanup 99bc00421 pprof CI flakes: enforce 5 seconds grace period 1d781ccbe [NO NEW TESTS NEEDED] rootless: declare TEMP_FAILURE_RETRY before usage (Fixes: #12563) 593d0907c --hostname should be set when using --pod new:foobar a63035be2 Cirrus: Use cached swagger binary 6d19ecadc inotify: make sure to remove files 18854f566 System tests: remove rm_pause_image() b526a0ccd specgen: honor empty args for entrypoint 2d517b687 generate systemd: support entrypoint JSON strings 6c05961ba Bump github.com/uber/jaeger-client-go d7f6f4e88 remove runlabel test for global opts 0999245e4 utils: reintroduce moveToCgroup 99e9fcdb6 autocopr: distro conditionals for containers-common d87a9b788 vendor c/image/v5@main 2130d1853 Update vendor or containers/common moving pkg/cgroups there 7d0fd175f volume: apply exact permission of target directory without adding extra 0111 851349345 Cirrus: Remove remnants of nix-based static build d35aa3f29 Refactor podman pods to report.Formatter 3753347d6 rootless netns: resolve all path components for resolv.conf eee3a42b7 tests: clean up FIXMEs and noise 207065ce9 fix remote run/start flake 6d7e6d744 e2e: fix pprof flakes c91fb244c Bump github.com/opencontainers/runc from 1.0.2 to 1.0.3 76f5100be vendor c/common@main 527fd3c0f Escape trailing slash in install directory location so the closing quote is not escaped e89a62602 centos 9 stream cannot use %autochangelog 7d22cc88e Refactor podman system to report.Formatter [NO NEW TESTS NEEDED] 8e0532623 add spec file for automated copr builds c9ad1da51 Add restart-sec option to systemd generate 2e132d1d4 Fix documentation of (podman image save --compress --uncompressed) 952046ffd Improve documentation of (podman image save --format) 7d331d35d Add support for configmap volumes to play kube bd9f8815e cmd, push: use the configured compression format aafbaa497 [CI:DOCS] logformatter: fix corner case with links ecd48325f UPdate vendor of image-spec and containers/storage fe1cdab59 vendor: update containers/common babc69367 Update doc to explictly mention using ed25519 in ssh keys 61792de36 Refactor podman image command output 6cb25b3d1 Manual fixes eb1212bed Same thing, with BeNumerically("==", x) c0a8814fb Use HaveLen(x) instead of Expect(len(y)).To(Equal(x)) 92f9e1176 Same thing, for BeNumerically("==", 0) 7c6123f8e Use BeEmpty() instead of len(x).To(Equal(0)) c67649546 Same as previous, for assertions other than Equal() 478f2da5d e2e tests: a little more minor cleanup 8d6d9df40 compat API: push: report size of manifest 2683ecbbc compat: images/json a0e696411 Add ashley-cui, lsm5 and floutoc to owners 65109494b remove ARTIFACT_DIR and ArtifactPath 3ac1b9bc0 Image caches: allow overriding cache dir 5ac66e2aa Rename CrioRoot as just Root 3ff47748d Fix possible rootless netns cleanup race db3a4c070 [NO NEW TESTS NEEDED] Refactor podman container command output 4e63f9192 Hostname in `spec.hostname` should be passed to infra ctr init opt 0afaf7837 container, cgroup: detect pid termination e2b344728 top: parse ps(1) args correctly 6673ff78d podman, push: expose --compression-format 9ce7ade8c e2e: yet more cleanup of BeTrue/BeFalse f415b3055 Ensure the generated NodePort values are unique a948ecbb9 Allow containerPortsToServicePorts to fail ec686d68d Don't use the global math/rand RNG for service ports d48c00418 Move a comment to the relevant place 8eb0be0a2 a few more manual BeTrue cleanups f7cbb1d84 Convert strings.Contains() to Expect(ContainSubstring) 12787963b e2e tests: more cleanup of BeTrue()s 5a56f4094 Implement 'podman run --blkio-weight-device' 9a10e2124 systemd: replace multi-user with default.target 5bdd571b1 compat API: allow enforcing short-names resolution to Docker Hub 0ddb09448 Fixed the containerfile not found during remote build. c80a2e449 podman-remote: prevent leaking secret into image e7204178e podman-remote: copy secret to contextdir is absolute path on host bfcaf538b api: allow build api to accept secrets 931c08157 Only open save output file with WRONLY f330c197b List /etc/containers/certs.d as default for --cert-path b63d69640 e2e tests: enable golint 697ff213d fix: parsing of HostConfig.Mounts for container create 2e50514ad Move the chown to after the ADDs cbda62d1b fix: error reporting for archive endpoint d5c3cc949 Bindings test: emit GIT_COMMIT, for links in logs bc3c5be2f checkpoint do not modify XDG_RUNTIME_DIR e648122b2 libpod: improve heuristic to detect cgroup a66f40b4d libpod, inspect: export cgroup path b25b33030 stats: get the memory limit from the spec 84e81252f compat: Add compatiblity with Docker/Moby API for scenarios where build fails c7ebaeee0 libpod: leave thread locked on errors eb3708a52 Find and fix empty Expect()s df6aa6730 Unset SocketLabel after system finishes checkpointing c034147fe Remove StringInSlice(), part 2 2fcb39586 Remove StringInSlice(), part 1 cd59721de e2e test cleanup, continued 533636395 Update basic_networking.md 5cf2683bf Warn on failing to update container status a4e4b8d92 oci: ack crun output when container is not there 08558b27f oci: exit gracefully if container is already dead dd80635df Support env variables based on ConfigMaps sent in payload 0d1aaf080 image lookup: do not match *any* tags 566b78dd0 generate systemd: add --start-timeout flag 49d63ad5c Oops! Manual edits to broken tests 97ab9176f e2e tests: clean up antihelpful BeTrue()s aa301225a Cirrus: Strip out static nix build 9c8fb5cc0 Rename pod on generate of container 2ab28140d [CI:DOCS] Update notes on java TZ in man page 73e95d1c3 Bump github.com/containers/image/v5 from 5.16.1 to 5.17.0 044edbb9c Fix netavark error handling and teardown issue 13ee1788f swagger: add layers to build api docs 022273c19 compat: add layer caching compatiblity for non podman clients f564c9a34 Bump github.com/opencontainers/selinux from 1.9.1 to 1.10.0 a8b3c67b9 Add note about volume with unprivileged container d173ebc06 Add EXPOSE e2e test 02be831ce Support EXPOSE with port ranges ab56a7c4b compat: Add subnet mask behind IP address to match Docker API d06899769 [CI:DOCS] Add java TZ note to run manpage 44b240470 Bump github.com/rootless-containers/rootlesskit from 0.14.5 to 0.14.6 21629b050 podman-remote does not support signature-policy ced0ffbe8 Add tests for restore runtime verification c76caba36 Use same runtime to restore a container as during checkpointing 8198e96f3 Force iptables driver for netavark tests 501643c8b Make sure netavark output is logged to the syslog 6011149ca filter: use filepath.Match to maintain consistency with other pattern matching in podman c03b6b54f Semiperiodic cleanup of obsolete Skip()s a3664269b [CI:DOCS]upload a translation file b2623ceb4 api/handlers: Add checkpoint/restore FileLocks 84021cfdc test: Update error string for --file-locks test 22ef7b620 fix duplicated logs command 19400ec0d Bump github.com/docker/docker 7f96a8d2d Bump k8s.io/api from 0.22.3 to 0.22.4 0dae50f1d Do not store the exit command in container config 7098463e7 Add test for checkpoint/restore with --file-locks 6d23ea60d Add --file-locks checkpoint/restore option 7f52bd843 Cirrus: Bump Fedora to release 35 3ee2d2367 Cirrus: Partially revert catatonit --force install 226be65bd Revert "Cirrus: Temp. disable prior-fedora testing" 5bd43fbea Cirrus: Workaround log_driver=journald setting f3021f3f6 Cirrus: Fix bindings test hang b/c logging config mismatch 155a443a9 Cirrus: Timeout bindings test after 30m 3aa7076ff Cirrus: Log more things in bindings and unit tests d6d1ce980 Minor Makefile fix 62d6b6bf7 rootless netns, one netns per libpod tmp dir 2e5d3e8fb Introduce Address type to be used in secondary IPv4 and IPv6 inspect data structure. e83d36665 volumes: add new option idmap fceecc3a5 remote checkpoint/restore: more fixes 6f6a6925b fix CI 010bee04c fix: take absolute path for dd on apple silicon d6c18902e System tests: new checkpoint tests 3073543fd rootless: use catatonit to maintain user+mnt namespace cb9de1007 rootless: drop strerror(errno) calls 084e32336 rootless: reuse existing open_namespace function 277d52686 rootless: use auto cleanup functions ee6271113 utils: use podman-pause-$RANDOM.scope name e367f4614 hack/bats: deal with new bin helpers 422dc5e69 Change error message for compatibility with docker 97c6403a1 rename libpod nettypes fields 8ca300ae9 podman machine start wait for ssh 33ec8c669 fix remote checkpoint/restore 44d1618dd Add --unsetenv & --unsetenv-all to remove def environment variables 364b242b7 Set config environment variables early in Podman init 63ef7135d journald logs: keep reading until the journal's end 014cc4b9d secret: honor custom target for secrets with run 5df883e87 bindings: reuse context for API requests 295d87bb0 podman machine improve port forwarding c21259bf8 Network test: fix podman-remote-rootless corner case c050f05cc filter: add basic pattern matching for label keys c8790bfbb cirrus: force-install catatonit 5934e4c9b infra container: replace pause with catatonit 58cf0d462 Revert "add kubernetes pause" d28b39a90 Added test for checkpoint/restore --print-stats 914f4c890 Update man pages for checkpoint/restore --print-stats 80e56fa12 Added optional container restore statistics 6202e8102 Added optional container checkpointing statistics 062c88771 Error logs --follow if events-backend != journald, event-logger=journald 9226ccb59 Enable 'podman run --memory-swappiness=0' 164c42b48 Fix network mode in play kube b1c002342 Always create working directory when using compat API f517510bc play kube: don't force-pull infra image ac38eca3f Podman Image SCP transfer patch 6762d5e23 --authfile command line argument for image sign command. f35d7f4dc Cirrus: Temp. disable prior-fedora testing 0b60b191d Cirrus: Update to Ubuntu 21.10 3af19917a Add failing run test for netavark fe90a45e0 Add flag to overwrite network backend from config 9f4d63f91 libpod: create /etc/mtab safely 8041d44c9 Add network backend to podman info b2f7430b6 Add more netavark tests 1c88f741a select network backend based on config 3fe0c4917 Fix RUST_LOG envar for netavark 4febe5576 netavark IPAM assignment eaae29462 netavark network interface 12c62b92f Make networking code reusable c43b81f9a Fix flake in upgrade tests 73e1cdfe9 export adding id-specifier code to setContainerNameForTemplate 980c47aaa VOLUME must be declared after RUN chown command 3690532b3 network reload return error if we cannot reload ports 27de152b5 network reload without ports should not reload ports a55fdbb49 Print headers for system connection ls 6236be4ff [CI:DOCS] Add CI check for SEE ALSO in man pages 1ef66d6d7 podman load: support downloading files 2720156fa Add links to all SEE ALSO sections df0666436 pod create: read infra image from containers.conf 9877280f5 rootless: adjust error message 216e2cb36 Fix rootless networking with userns and ports faf450ea1 support health checks from image configs 6ee3b33d3 change from run to create in 250-systemd.bats d0b502fce Exclude already built sources for static build 72cf38968 shm_lock: Handle ENOSPC better in AllocateSemaphore 8a9da7698 Fix Zsh completion command documentation 555e21557 Match .c files in Makefile 65609f338 Add Static Build download instructions to README 7225ddb5b Add links to podman build,run, create see also 2ed31f9f1 Minor test tweaks 8b7b0b7ca pod create: read network mode from config 5fbc67f20 Bump Catatonit up to v0.1.7 e907f095b test connection add 338eb9d75 system: Adds support for removing all named destination via --all 6444f2402 pod/container create: resolve conflicts of generated names f3fab1e17 podman-generate-kube - remove empty structs from YAML 4e8bf8be4 Add some information about disabling SELinux when using system volumes 02f67181a Fix swagger definition for the new mac address type 5c0351cc6 Log Apache access_log-like entries at Info level [NO NEW TESTS NEEDED] 3e1940a8e Test to check for presence of 'stats-dump' in exported checkpoints 6b8fc3bd1 Add 'stats-dump' file to exported checkpoint ffa5ed0e0 Podman Image SCP rootful to rootless transfer 7f433df7e rename rootless cni ns to rootless netns 58f8c3d74 mount full XDG_RUNTIME_DIR in rootless cni ns 6fee827c7 Bump github.com/checkpoint-restore/go-criu/v5 from 5.1.0 to 5.2.0 756dda298 Keep error semantics intact 614c6f597 Fix rootless cni netns cleanup logic b85e3764a tweak a couple of flag descriptions in help output ff92d7371 Update swagger doc make filed optional ba8eba83e Fix bindings container log test 0234b153c test: run --cgroups=split in new cgroup 001d48929 MAC address json unmarshal should allow strings 6e6388eac Make stop message more similar to start 449cc7a5c Implement top streaming for containers and pods f2115471d Handle HTTP 409 error messages properly for Pod actions d0dfc5e22 Add tests 48d0d2b4a Fix swagger definitions 48e1cca9f More conforming libpod API and swagger types 62ee24bb7 More conforming libpod API and swagger types a845613d0 Better emptiness test for custom JSON serializer 7b2531c13 System tests: enhance volume test, add debug prints 15eb01601 add unit test to containers_test 120ad2d3c Use correct swagger type in doc-comment 9c34bd52f Cirrus: Authorize rootless user self-ssh 218d91d76 Fix libpod API conformance to swagger e69eae645 Fix help message case for `podman version` 9fc98f265 Fix pause usage example 749487600 Use systemctl in local system test 98506c961 Allow label and labels when creating volumes c5f0a5d78 volumes: be more tolerant and fix infinite loop 3c79202fb Add information on how podman machine is updated 4e9e6f21f volumes: allow more options for devpts e6286fbac volumes: do not pass mount opt as formatter string feebf1bd8 Bump k8s.io/api from 0.22.2 to 0.22.3 960831f9c runtime: change PID existence check 9e5cd3205 oci: rename sub-cgroup to runtime instead of supervisor 0136a66a8 libpod: deduplicate ports in db e68fbf03a Set flags to test 'logs -f' with journald driver dcbf5cae1 Set Checkpointed state to false after restore ff31f2264 container create: fix --tls-verify parsing 6b3b0a17c runtime: check for pause pid existence 825889cc7 utils: do not overwrite the err variable d53789068 Fix systemd PID1 test 864748df5 Record the image stream along with the path 55397de93 cgroups: use SessionBusPrivateNoAutoStartup 8163d38c6 vendor: update godbus to v5.0.6 008075ce5 Slirp4netns with ipv6 set net.ipv6.conf.default.accept_dad=0 c723e6b97 Fix a few problems in 'podman logs --tail' with journald driver bf8fd943e Allow 'container restore' with '--ipc host' efd1c080b Document to not set K8S envars for CNI 773caf293 Bump github.com/docker/docker 75f478c08 pod create: remove need for pause image 9d2b8d279 add kubernetes pause e86549b18 cirrus: containers: mount directory in /var/tmp to /tmp 2e3611d61 overlay root fs: create mount on runtime dir a42c131c8 Update vendor github.com/opencontainers/runtime-tools d6296c918 If Dockerfile exists in same directory as service, we should not use it. adee084d6 Fix tests of podman image trust --raw and --json 53ff49237 Tighten the expected output of the "podman image trust show" test c872788e4 Use INTEGRATION_ROOT instead of current directory acd8b4900 Add support to play kube for --log-opt d7662edf6 [NO NEW TESTS NEEDED] Fix off-by-one index comparision (reported by LGTM) 24c83980e Fix some typos in documentation and comments (found by codespell) 22270fb84 Replace 'an user' => 'a user' 936ab158c [CI:DOCS] Fix typo keep_id -> keep-id 38c78381c Set DOCKER_HOST in the VM ce4ed7d13 fuse-overlay probably means fuse-overlayfs. ece0c7e5d Support template unit files in podman generate systemd 8e3760c29 Remove --kernel-memory options f4f96962c tag: Support tagging manifest list instead of resolving to images 30245f584 Remove infra ID from DB before removing containers 70a5d8cd1 System tests: confirm that -a and -l clash 12d0a8509 systemd: compatible with rootless mode 960a55c09 system tests: CONTAINER_* and --help: cleanup 20b5a8599 podman run --memory=0 ... should not set memory limit c3801f0fa Add information on how to discover default log driver d24ce0a33 Add test for system connection 517b56b02 Generate Kube should not print default structs 9500e11a8 libpod: change mountpoint ownership c.Root when using overlay on top of external rootfs 34dcbc949 Change podman connection list to use default field 087f8fc73 Allow API to specify size and inode quota db7a98de4 Use exponential backoff when waiting for a journal entry 4f7a431da Pod Rm Infra Improvements c8cffe1b3 system tests: socket activation: clean up d0f7b99c6 rootfs-overlay: fix overlaybase path for cleanups 468e7c689 Move CONTAINER_HOST and _CONNECTION to IsRemote Function 207abc4a9 We should only be relabeling when on first run 4f857bc10 If CONTAINER_HOST env variable is set default podman --remote=true 8db62d04f Set targetPort to the port value in the kube yaml 16e7cc8bf Do not add TCP to protocol in generated kube yaml ab4c9a894 Use CGO_ENABLED=1 when building natively on darwin c1497cf44 Test-hang fix: Wait for ready + timeout on connect. 8439a6d5e Checkpoint/Restore test fixes f9ff0525c Don't include ctr.log if not using file logging 50b9d82f2 Don't use docker/pkg/archive, use containers/storage/pkg/archive 7112a4159 Fix codespell errors 184de3955 Adjust tests to verify all subcommands show the help message 8cae2978e Fix panic in container create compat api 5d18fb923 Don't add image entrypoint to the generate kube yaml cc875fd26 Display help text on empty subcommand by default 14bfee31f podman search: display only name and description by default 8600bce53 codespell code 7b1e386f7 Add information about .containerignore to podman build man page cead18537 CNI: fix network create --ip-range 4631f5b28 Kube Gen run as user/group issues 3ba69dccf rootlessport: reduce memory usage of the process ab0e6630f No space in kube annotations for bind mounts 0459484bd Fix CI flake on time of shutdown for API service b28a8bc19 Refactor podman search to be more code friendly 69b665996 Unit files: Use actual installed path for podman 1e81787e3 Bump github.com/onsi/ginkgo from 1.16.4 to 1.16.5 9042520cf cgroups: use cgroup.controllers to read controllers ab8fb3876 builder: Add support for builder prune 7580c2273 Remove a volume with --force if container is running 6b2939884 Use SplitN(2) when copying env variables e57b32c59 podman stats: move cgroup validation to server 54471acba fix test dd5975f3d Support readonly rootfs contains colon 90b5318b8 [CI:DOCS] oci-hooks.5.md: fixup section in header 8d3aec9d0 Enable /debug/pprof API service endpoints 5caf6b94e Not all fields in machine list were set properly fad14dafe faster image inspection 48d26a893 Warn if podman stop timeout expires that sigkill was sent 6fc73ea4e [CI:DOCS] introduce --replace flag for play kube 0479fd8d6 [CI:DOCS] Include manifest example usage a487a6382 Change podman.1 man page to show corret log-level default da8e4cdeb Bump github.com/opencontainers/selinux from 1.8.5 to 1.9.1 6f9e9ee9e Fixes #11668 fbce7584d libpod: fix race when closing STDIN 8bd9f58d1 Ensure `podman ps --sync` functions e1089e89d Allow `podman stop` to be run on Stopping containers 675d2d0c1 Bump github.com/containers/image/v5 from 5.16.0 to 5.16.1 033a662b9 Bump github.com/docker/docker 521c0cbd1 It really should be no **NEW** tests needed fb118b852 README.md: Point to Podman's channels 8e80f4d24 Add podman-plugins to upstream image a726043d0 CNI networks: reload networks if needed 8156df5b7 bump c/common to latest and c/storage to 1.37.0 21c9dc3c4 Add --time out for podman * rm -f commands d6b9451b4 Cirrus: Fix defunct package metadata breaking cache 163d81cc0 Pod Events Logging Fix c67593df1 [NO TESTS NEEDED] Ignore removed containers 6da97c863 Pod Volumes From Support 4ea5d6971 Add note about empty fields and null values for API responses 97bf6331f Bump github.com/containers/buildah from 1.23.0 to 1.23.1 641f0ccc4 Add podman play kube --no-hosts options fb2355adb Gating tests: fix permissions error 686b7ef7b pkg/specgen: cache image in generator 0b5a2b746 cirrus: gitlab: download packages 648882bf6 Add guard for BuildOptions.CommonBuildOpts bf94ebf42 System tests: tighten 'is' operator 7e81d78ed Update README and release notes for v3.4.0 cc4232169 sdnotify test: accept MAINPID anywhere 642d68299 machine: silently cleanup dangling sockets before rm if possible a1dce3a0d Add expose type map[uint16]string to description 0a156211d [NO TESTS NEEDED] Fix typo in storage.conf file exists message 1ff6a5082 Support selinux options with bind mounts play/gen 9c6c98192 kube: fix conversion from milliCPU to period/quota 5090920cc Bump github.com/mattn/go-isatty from 0.0.12 to 0.0.14 5c1b3e8d7 test: use new helper 788106dad test: skip test on rootless cgroupsv1 5a33b7aef machine: Info on successfully stopping qemu machine c25cc7230 Allow a value of -1 to set unlimited pids limit 1805ed360 Vendor in latest containers/storage c9ea2cae1 Storage can remove ErrNotAContainer as well ccff77025 libpod: container create: init variable: do not deep copy spec 5ea369ade libpod: add GetConfigNoCopy() 30bf31010 libpod: add execSessionNoCopy 98176f001 libpod: do not call (*container).Spec() 2d8605189 Pod Device-Read-BPS support 97f755f87 Remind user to check connection or use podman machine 678b554b1 Ensure pod ID bucket is properly updated on rename 60824c613 Fix contributor make targets on Ubuntu and Debian 0d4fa7bc9 Implement PR template to assist review & release 5d6ea90e7 libpod: do not call (*container).Config() a3cdee979 [NO TESTS NEEDED] Add port configuration to first regular container d14f66972 [CI:DOCS] cmd/podman: no dot for short descriptions 1c8926285 move network alias validation to container create d0950f3ef set --cni-config-dir for exit command 05614ee13 always add short container id as net alias a9a54eefa image prune: support removing external containers 86083c580 System tests: speed up. They've gotten too slow. 344ba32c8 Add dockerfile.5 as man link to containerfile man page 87559b020 Set MSI to be 64-bit only. ca3c08bf9 fix podman network prune integration test flakes f76fa3475 Cirrus: Add gitlab podman runner test 1df0646b0 CNI: network remove do not error for ENOENT 464fec260 remote build: EvalSymlinks() the context directory 8fca626e3 stop: Do nothing if container was never created in runtime 3ce98a5ec logging: new mode -l passthrough 3600054d1 Allow machine options to be set from containers.conf 5a2ca77b9 Vendor in containers/common v0.46.0 c668ca859 podman machine: do not join userns b3307bc9c Disable docker and alias to podman in FCOS ignition 1e0039a83 added healthcheck to ps command a97551eb2 Fix english on prune prompt 3d8dec982 Document missing /images/search query parameters 6095c4fac rootful: do not set XDG_RUNTIME_DIR for cni plugins 1cf66f514 Revert "rootful: unset XDG_RUNTIME_DIR" ba46613a6 Add completion for machine list format 2df0685cb Set context dir for play kube build ce080d25c Makefile: use -ldflags/-gccgoflags depending on the go implemenatiton 82818caff Update docs for --platform in podman-build.1 b6e5a4909 shell completion: do not show images without tag 119973375 podman inspect add State.Health field for docker compat 01bf8a668 podman save: enforce signature removal 4ecaf85d9 Add JSON version of the machine list ed3c4a89d Add support for :U flag with --mount option 2d5d98c04 [CI:DOCS] Add link to running ctrimage on enablesysadm b6fecbb75 Ignore mount errors except ErrContainerUnknown when cleaningup container 1c4e6d862 standardize logrus messages to upper case 45ee5c5db podman generate kube should not include images command f5f95d722 Fix machine image db44addf9 sync container state before reading the healthcheck 0baee2cc3 Also show the (initial) disk size 911298252 Show cpus and memory in machine list 5acf8ae12 Eighty-six eighty-eighty 68d21b6ff net types: remove omitempty from required fields 49c5688a3 podman save: add `--uncompressed` af49810a6 Bump CNI to v1.0.1 5875e409e vendor c/[email protected] 738f2b36e [CI:DOCS] Add network alias note in man pages 4ecbc7caa Add a backoff and retries to retrieving exited event 319fcf52f Cross-build release-archives w/ arch in filename 34043bd81 Fix Error, empty output for info: 'VERSION' 185294cb8 Generate kube should'd add podman default environment vars ae5de8b39 volume: Add support for overlay on named volumes 8fac34b8f Pod Device Support 8453c8ce6 Support --format tables in ps output 61217f3ba Remove references to kube being development b74edfb0a Add support for retrieving system service --timeout 3221f50a4 Add podman image/container inspect man pages 665b451e5 [CI:DOCS] Add link to skopeo delete in podman rmi 509812457 vendor c/common@main 92ee2f372 remote untag: support digests cb077c968 Created MapOptions for PodCreate a1861c570 Bump k8s.io/api from 0.22.1 to 0.22.2 5242030ac compat API: /images/json prefix image id with sha256 cf28dab9f podman machine: use gvproxy for host.containers.internal eea5d2512 utils: return error message from StartTransientUnit 4caca0969 utils: raise warning only on cgroupv2 74ad05396 Add podman machine init --now option 22df773f7 System tests: cleanup, and remove obsolete skips e3e9e5175 Add username flag for machine ssh c692f7a18 Remove unused code from libpod 62350fed6 [CI:DOCS] markdown cleanup 613ef220f Fix up build the docs site 7ca666f47 Use a new markdown converter for sphinx a2c8b5d9d runtime: move pause process to scope 72534a74b system: move MovePauseProcessToScope to utils 9c1e27fdd system: always move pause process when running on systemd fa9728c55 system: avoid reading pause pid file f1ee23425 Only add 127.0.0.1 entry to /etc/hosts with --net=none 4216f7b7f Add no-trunc support to podman-events aee0ab98c CNI: add ipvlan driver c20f61148 CNI: network create support macvlan modes 5c7935057 Do not allow network modes to be used as network names 9c091e42d fix inverted condition 7c5d64b47 Fix /auth compat endpoint 5e8309464 Add Drivers method to the Network Interface 1bcd006c5 CI: load ipv6 kernel modules for rootless tests b906b9d85 Drop OCICNI dependency 85e8fbf7f Wire network interface into libpod 218f132fd cni network configs set ipv6 enables correctly 24bec9a76 default network: do not validate the used subnets aa7bc4e37 network create: validate the input subnet 3e77f960f Set default storage from containers.conf for temporary images 0b1c45bc5 container runlabel remove image tag from name 962675c14 build.bats: fix copy tests after containers/buildah#3486 d0c605cd3 build: mirror --authfile to filesystem if pointing to FD instead of file 5cafb6d18 Fix example in podman machine init man page 222b62e7b vendor: Bump github.com/containers/buildah from 1.22.3 to 1.23.0 9b04e1789 api: handle nil pointer dereference in rest endpoints 5dbf3ee7a build: take advantage of --platform lists 64de4f612 Document `all` query parameter for /libpod/images/prune 38c5f6721 Show variant and codename of the distribution 952fc4a6f Use new aarch64 fcos repos d7256be80 Enhance bindings for IDE hints 84005330a Pod Volumes Support b1768d3b0 test: enable --cgroup-parent test 44abc1797 libpod: honor --cgroups=split also with pods 65f3b16c6 tests: enable --cgroups=disabled test for rootless afe4d17be tests: simplify --cgroups=disabled test d3f0f09ad libpod: rootful close binded ports 072b061b4 Search gvproxy with config.FindHelperBinary() a55e2a00f rootfs: Add support for rootfs-overlay and bump to buildah v1.22.1-0.202108 6221f269a fix restart always with rootlessport d30facfda Cirrus: NM/CNI workaround + Remove prior-Ubuntu ba2130ff5 If container exits with 125 podman should exit with 125 9ae947654 Bump github.com/json-iterator/go from 1.1.11 to 1.1.12 b0cbcd1d0 bump c/common to v0.44.0 32424d9a9 remove rootlessport socket to prevent EADDRINUSE 3c77a98e4 Add deprecated fields for 1.22+ clients that still expect them 7a667c4ac Use default username for podman machine ssh Signed-off-by: Bruce Ashfield <[email protected]>

Aditya R (8): vendor: bump c/common and other vendors compat: images/load must be able to load tar with multiple images compat: remove hardcoded index from load images output report ignition, machine: delegate cpu,io cgroup controllers to machine's default users healthcheck, libpod: Read healthcheck event output from os pipe tests: retrofit healthcheck system tests compat: endpoint /build must set header content type as application/json in reponse kube: honor --build=false and make --build=true by default Aditya Rajan (33): vendor: Bump github.com/containers/buildah from 1.22.3 to 1.23.0 build: mirror --authfile to filesystem if pointing to FD instead of file build.bats: fix copy tests after containers/buildah#3486 volume: Add support for overlay on named volumes stop: Do nothing if container was never created in runtime machine: Info on successfully stopping qemu machine machine: silently cleanup dangling sockets before rm if possible builder: Add support for builder prune rootfs-overlay: fix overlaybase path for cleanups libpod: change mountpoint ownership c.Root when using overlay on top of external rootfs tag: Support tagging manifest list instead of resolving to images system: Adds support for removing all named destination via --all filter: add basic pattern matching for label keys secret: honor custom target for secrets with run filter: use filepath.Match to maintain consistency with other pattern compat: add layer caching compatiblity for non podman clients swagger: add layers to build api docs oci: exit gracefully if container is already dead oci: ack crun output when container is not there compat: Add compatiblity with Docker/Moby API for scenarios where build fails api: allow build api to accept secrets podman-remote: copy secret to contextdir is absolute path on host podman-remote: prevent leaking secret into image volume: apply exact permission of target directory without adding extra 0111 specgen: honor empty args for entrypoint build: relay exitcode from imagebuildah to registry tests: adjust old build test to expect exit code docs: sort swagger operations alpabetically ignition: add certs from current user into the machine while init ignition: propogate HTTP proxy variables from host to remote ignition: add support from setting SSL_CERT_FILE pkg: use PROXY_VARS from c/common volume: add support for non-volatile upperdir,workdir for overlay volumes Adrian Reber (18): Checkpoint/Restore test fixes Allow 'container restore' with '--ipc host' Set Checkpointed state to false after restore Add 'stats-dump' file to exported checkpoint Test to check for presence of 'stats-dump' in exported checkpoints Added optional container checkpointing statistics Added optional container restore statistics Update man pages for checkpoint/restore --print-stats Added test for checkpoint/restore --print-stats Use same runtime to restore a container as during checkpointing Add tests for restore runtime verification Add more checkpoint/restore information to 'inspect' Test for checkpoint specific inspect fields [CI:DOCS] Explicitly mention that checkpointing systemd containers might fail [CI:DOCS] Small checkpoint/restore man page fixes Update go-criu to v5.3.0 Error out early if system does not support pre-copy checkpointing Fix checkpoint/restore pod tests Ambrose Chua (1): compat: Add subnet mask behind IP address to match Docker API Ananth Bhaskararaman (1): Fixes #12063 Add docker compatible output after image build. Anders F Björklund (15): Show variant and codename of the distribution Show cpus and memory in machine list Also show the (initial) disk size Add JSON version of the machine list Add completion for machine list format Fix contributor make targets on Ubuntu and Debian Not all fields in machine list were set properly Record the image stream along with the path Make stop message more similar to start [CI:DOCS] Add example of cpus to init command Implement virtfs volumes for podman machine Check the mount type for future compatibility Make it possible to select the volume driver Show package version when running on alpine Restore machine start logic that was hanging Andrzej Klajnert (1): Recursively copy cert files. Ashley Cui (6): Use default username for podman machine ssh Add username flag for machine ssh Fix machine image Allow machine options to be set from containers.conf Remind user to check connection or use podman machine Add information on how podman machine is updated Boaz Shuster (6): Support template unit files in podman generate systemd Use systemctl in local system test add unit test to containers_test podman-generate-kube - remove empty structs from YAML change from run to create in 250-systemd.bats export adding id-specifier code to setContainerNameForTemplate Brent Baude (18): Remove references to kube being development Set context dir for play kube build Support selinux options with bind mounts play/gen No space in kube annotations for bind mounts Rename pod on generate of container Set machine timezone Removed .service file for healthchecks .service file removal on failure fix healthcheck timeouts and ut8 coercion Wait for podman stop to complete netavark e2e tests Temporarily pull machine images from side repo Changes of docker descriptions Fix images since/after tests Changes of docker descriptions Fix images since/after tests Revert "Option --url and --connection should imply --remote." Revert "use GetRuntimeDir() from c/common" Chen Zhiwei (1): [CI:DOCS] introduce --replace flag for play kube Chris Evich (44): Cirrus: NM/CNI workaround + Remove prior-Ubuntu Fix Error, empty output for info: 'VERSION' Cross-build release-archives w/ arch in filename Cirrus: Add gitlab podman runner test Implement PR template to assist review & release Cirrus: Fix defunct package metadata breaking cache [CI:DOCS] Include manifest example usage Test-hang fix: Wait for ready + timeout on connect. Fix systemd PID1 test Cirrus: Authorize rootless user self-ssh Bump Catatonit up to v0.1.7 Cirrus: Update to Ubuntu 21.10 Cirrus: Temp. disable prior-fedora testing Minor Makefile fix Cirrus: Log more things in bindings and unit tests Cirrus: Timeout bindings test after 30m Cirrus: Fix bindings test hang b/c logging config mismatch Cirrus: Workaround log_driver=journald setting Revert "Cirrus: Temp. disable prior-fedora testing" Cirrus: Partially revert catatonit --force install Cirrus: Bump Fedora to release 35 Cirrus: Strip out static nix build Cirrus: Remove remnants of nix-based static build Cirrus: Use cached swagger binary Cirrus: Temp. ignore gitlab task failures Revert "Cirrus: Temp. ignore gitlab task failures" Cirrus: Freshen VM images Cirrus: Temporarily disable OSX Cross task Revert "Cirrus: Temporarily disable OSX Cross task" Github workflow: Update Cirrus-cron GraphQL query Github workflow: Send e-mail on job error Github-workflow: Fix YAML syntax Github workflow: Fix parsing of GraphQL response JSON Cirrus: Fix get_ci_vm.sh initial setup Cirrus: Add e2e task w/ upstream netavark Cirrus: Also download aardvark-dns binary Cirrus: Add netavark/aardvark system test task Cirrus: Log netavark/aardvark binary build info. Cirrus: Add [CI:BUILD] magic that only builds Cirrus: Minor - limit release task applicability Cirrus: Expand netavark testing to include rootless Cirrus: TODO: netavark/aardvark release branches Cirrus: Update VM Images for 4.0 release Cirrus: Disable F34 aka prior-fedora testing Christoph Petrausch (1): Don't rename pod if container has the same name Colin Bendell (2): Support EXPOSE with port ranges Add EXPOSE e2e test Colin Walters (1): Don't segfault if an image layer has no creation timestamp Daniel Helfand (1): change location of where make outputs podman binary on osx Daniel J Walsh (97): If container exits with 125 podman should exit with 125 Set default storage from containers.conf for temporary images Add no-trunc support to podman-events Fix up build the docs site Add podman machine init --now option Add podman image/container inspect man pages Add support for retrieving system service --timeout Generate kube should'd add podman default environment vars podman generate kube should not include images command standardize logrus messages to upper case Ignore mount errors except ErrContainerUnknown when cleaningup container Fix english on prune prompt Vendor in containers/common v0.46.0 Add dockerfile.5 as man link to containerfile man page Storage can remove ErrNotAContainer as well Vendor in latest containers/storage Add podman play kube --no-hosts options Add --time out for podman * rm -f commands Change podman.1 man page to show corret log-level default Warn if podman stop timeout expires that sigkill was sent Remove a volume with --force if container is running Add information about .containerignore to podman build man page codespell code Fix codespell errors Don't use docker/pkg/archive, use containers/storage/pkg/archive Don't include ctr.log if not using file logging If CONTAINER_HOST env variable is set default podman --remote=true We should only be relabeling when on first run Move CONTAINER_HOST and _CONNECTION to IsRemote Function Allow API to specify size and inode quota Change podman connection list to use default field Generate Kube should not print default structs Add information on how to discover default log driver podman run --memory=0 ... should not set memory limit Remove --kernel-memory options Add support to play kube for --log-opt If Dockerfile exists in same directory as service, we should not use it. Update vendor github.com/opencontainers/runtime-tools Add some information about disabling SELinux when using system volumes Add links to podman build,run, create see also Add links to all SEE ALSO sections Error logs --follow if events-backend != journald, event-logger=journald Set config environment variables early in Podman init Add --unsetenv & --unsetenv-all to remove def environment variables podman-remote does not support signature-policy Bump github.com/rootless-containers/rootlesskit from 0.14.5 to 0.14.6 Unset SocketLabel after system finishes checkpointing Move the chown to after the ADDs List /etc/containers/certs.d as default for --cert-path Only open save output file with WRONLY Add ashley-cui, lsm5 and floutoc to owners compat API: push: report size of manifest UPdate vendor of image-spec and containers/storage Update vendor or containers/common moving pkg/cgroups there --hostname should be set when using --pod new:foobar Show --external containers even without --all option Use hosts public ip address in rootless containers Warn on use of --kernel-memory Allow users to add host user accounts to /etc/passwd Update swagger documentation test/system: podman run with log-opt option test/system: podman run image with filesystem permission Fix Container List API call to return mount info Support all volume mounts for rootless containers Change Tests to ignore missing containers when removing --all Fix CI Set volume NeedsCopyUp to false iff data was copied up add OCI Runtime name to errors Remove dead RuntimeOption functions Use the InfraImage defined in containers.conf Pretty Print output of podman machine ls --format json It takes some time to start a VM Add podman rm --depend Fix permission on secrets directory add additional fields to podman machine ls --json Add --noout option to prevent the output of ids use events_logfile_path from containers.conf for events log. Remove two GetImages functions from API test/system: podman run update /etc/hosts Standardize on capatalized Cgroups Fix cgroup mode handling in api server Use PODMAN_USERNS environment variable when running as a service Handle changes in docker compat mode Fix #2 for compat commit handling of --changes Run codespell on code Show correct default values or show none Fix handling of duplicate matches on id expansion Fix sort ordering of filters Fix use of infra image to clarify default Clarify remote client means Mac and Windows Fix size to match Docker selection Only change network fields if they were actually changed by the user Move each search dns to its own line Vendor in containers/buildah v1.24.1 idmap should be able to be specified along with other options Make sure building with relative paths work correctly. Don't log errors on removing volumes inuse, if container --volumes-from David Gibson (4): Don't explicitly check for crun|runc in package information Make error message matching in 030-run.bats less fragile tests: Remove inaccurate comment Propagate $CONTAINERS_CONF to conmon David Marshall (1): correct typo words in docs Easton Man (1): systemd: compatible with rootless mode Easton Pillay (1): Set MSI to be 64-bit only. Ed Santiago (61): [CI:DOCS] markdown cleanup System tests: cleanup, and remove obsolete skips Eighty-six eighty-eighty System tests: speed up. They've gotten too slow. sdnotify test: accept MAINPID anywhere System tests: tighten 'is' operator Gating tests: fix permissions error It really should be no **NEW** tests needed Unit files: Use actual installed path for podman system tests: socket activation: clean up Add test for system connection system tests: CONTAINER_* and --help: cleanup System tests: confirm that -a and -l clash System tests: enhance volume test, add debug prints Minor test tweaks [CI:DOCS] Add CI check for SEE ALSO in man pages Network test: fix podman-remote-rootless corner case hack/bats: deal with new bin helpers System tests: new checkpoint tests Semiperiodic cleanup of obsolete Skip()s e2e tests: clean up antihelpful BeTrue()s Oops! Manual edits to broken tests e2e test cleanup, continued Remove StringInSlice(), part 1 Remove StringInSlice(), part 2 Find and fix empty Expect()s Bindings test: emit GIT_COMMIT, for links in logs e2e tests: enable golint e2e tests: more cleanup of BeTrue()s Convert strings.Contains() to Expect(ContainSubstring) a few more manual BeTrue cleanups e2e: yet more cleanup of BeTrue/BeFalse Rename CrioRoot as just Root Image caches: allow overriding cache dir remove ARTIFACT_DIR and ArtifactPath e2e tests: a little more minor cleanup Same as previous, for assertions other than Equal() Use BeEmpty() instead of len(x).To(Equal(0)) Same thing, for BeNumerically("==", 0) Use HaveLen(x) instead of Expect(len(y)).To(Equal(x)) Same thing, with BeNumerically("==", x) Manual fixes [CI:DOCS] logformatter: fix corner case with links tests: clean up FIXMEs and noise System tests: remove rm_pause_image() apiv2 tests: refactor complicated curls APIv2 tests: fail on syntax/logic errors Emergency system-test fixes System tests: fix RHEL8 gating tests buildah bud tests: skip failing tests podman image scp: implement --quiet Manual fixes for PR #12642: [WIP] Tests for podman image scp (the sudo form) CI: rootless user: also create in some root tests APIv2 tests: followup to recent log test System tests: fix for new systemd on rawhide CI: enable rootless-remote system tests System tests: emergency skip of checkpoint tests System tests: revert emergency skip of checkpoint tests Cleanup: remove obsolete/misleading bug workaround System tests: show one-line config overview Eduardo Vega (1): Add support for :U flag with --mount option Erik Sjölund (8): [CI:DOCS] Fix typo keep_id -> keep-id [CI:DOCS] Fix typo in --env [CI:DOCS] Unprivileged native overlayfs is now supported [CI:DOCS] fix default branch links fix default branch links [CI:DOCS] fix typo subpordinate [CI:DOCS] Fix typos and improve language [CI:DOCS] Fix typos and improve language Ethan Soucy (1): [NO TESTS NEEDED] Fix typo in storage.conf file exists message Evan Lezar (2): Use new CDI API Use fully-qualified device name in CDI test Federico Gimenez (1): Introduce Address type to be used in secondary IPv4 and IPv6 inspect data Giacomo Sanchietti (1): Fix pause usage example Giuseppe Scrivano (61): tests: simplify --cgroups=disabled test tests: enable --cgroups=disabled test for rootless libpod: honor --cgroups=split also with pods test: enable --cgroup-parent test system: avoid reading pause pid file system: always move pause process when running on systemd system: move MovePauseProcessToScope to utils runtime: move pause process to scope utils: raise warning only on cgroupv2 utils: return error message from StartTransientUnit logging: new mode -l passthrough test: skip test on rootless cgroupsv1 test: use new helper kube: fix conversion from milliCPU to period/quota cgroups: use cgroup.controllers to read controllers vendor: update godbus to v5.0.6 cgroups: use SessionBusPrivateNoAutoStartup utils: do not overwrite the err variable runtime: check for pause pid existence oci: rename sub-cgroup to runtime instead of supervisor runtime: change PID existence check volumes: do not pass mount opt as formatter string volumes: allow more options for devpts test: run --cgroups=split in new cgroup rootless: adjust error message libpod: create /etc/mtab safely utils: use podman-pause-$RANDOM.scope name rootless: use auto cleanup functions rootless: reuse existing open_namespace function rootless: drop strerror(errno) calls rootless: use catatonit to maintain user+mnt namespace volumes: add new option idmap libpod: leave thread locked on errors stats: get the memory limit from the spec libpod, inspect: export cgroup path libpod: improve heuristic to detect cgroup podman, push: expose --compression-format container, cgroup: detect pid termination vendor: update containers/common cmd, push: use the configured compression format utils: reintroduce moveToCgroup oci: configure the devices cgroup with default devices .github: revert to the old template rootless: include the args in the debug message test: add --rm to podman run commands build: fix test for subid 4 vendor: update containers/storage specgen: honor userns=auto from containers.conf ci: force scratch build for crun [CI:DOCS] docs: document rootless userns mappings libpod: refine check for empty pod cgroup libpod: fix check for systemd session rootless: report correctly the error libpod: fix connection leak libpod: fix leaking fd exec: retry rm -rf on ENOTEMPTY and EBUSY rootless: drop permission check for devices libpod: report slirp4netns network stats libpod: enforce noexec,nosuid,nodev for /dev/shm docs: clarify rootless net stats kube: honor mount propagation mode Gábor Lipták (1): Add Static Build download instructions to README Hironori Shiina (4): Fix a few problems in 'podman logs --tail' with journald driver Set flags to test 'logs -f' with journald driver Enable 'podman run --memory-swappiness=0' Implement 'podman run --blkio-weight-device' Hongyi Shen (1): Update doc to explictly mention using ed25519 in ssh keys Hyeon Kim (1): Search gvproxy with config.FindHelperBinary() Ian Wienand (2): Match .c files in Makefile shm_lock: Handle ENOSPC better in AllocateSemaphore Jake Parks (1): Fixes #11668 Jakub Dzon (1): Support env variables based on ConfigMaps sent in payload Jakub Guzik (3): Add secret list --filter to cli Unify the method of parsing filters in cmd Remove unused param and clean API handlers Jason T. Greene (11): Add deprecated fields for 1.22+ clients that still expect them Disable docker and alias to podman in FCOS ignition Escape trailing slash in install directory location so the closing quote is not escaped Switch to a new installer approach using a path manipulation helper Introduce Windows WSL implementation of podman machine Fix type-o in podman.wxs Implement env parsing on Windows Implement API forwarding for podman machine on Windows Update to podman4 copr stream Initial implementation of mac forwarding using a privileged docker sock claim helper Introduce podman machine init --root=t|f and podman machine set --root=t|f Jelle van der Waa (3): Document `all` query parameter for /libpod/images/prune api: handle nil pointer dereference in rest endpoints Document missing /images/search query parameters Jhon Honce (23): Enhance bindings for IDE hints Support --format tables in ps output Add guard for BuildOptions.CommonBuildOpts [NO TESTS NEEDED] Ignore removed containers Enable /debug/pprof API service endpoints Use SplitN(2) when copying env variables Refactor podman search to be more code friendly Fix CI flake on time of shutdown for API service Use CGO_ENABLED=1 when building natively on darwin Allow label and labels when creating volumes Implement top streaming for containers and pods Log Apache access_log-like entries at Info level [NO NEW TESTS NEEDED] test connection add [NO NEW TESTS NEEDED] Refactor podman container command output Refactor podman image command output Refactor podman system to report.Formatter Refactor podman pods to report.Formatter Refactor manifest list operations Engine.Remote from containers.conf Update godoc, swagger using wrong struct Add version guard to libpod API endpoints Add 409 response to swagger godoc Fix manifest 4.0 Endpoints Jindrich Novy (1): VOLUME must be declared after RUN chown command José Guilherme Vanz (1): --authfile command line argument for image sign command. Junichi Uekawa (1): fuse-overlay probably means fuse-overlayfs. Kir Kolyshkin (4): test/e2e/run: don't use date +%N on Alpine test/e2e/pod_initcontainers: fix a flake SECURITY.md: fix the project name pkg/specgen/generate/security: fix error message Leah Neukirchen (3): legacy events: also set Action="die" legacy events: also set exitCode remote events: convert TimeNano properly Lokesh Mandvekar (11): README.md: Point to Podman's channels add spec file for automated copr builds centos 9 stream cannot use %autochangelog autocopr: distro conditionals for containers-common Add rpkg template for COPR autobuild [NO NEW TESTS NEEDED] add builddeps to copr template Makefile: install targets independent of build CI: fix nightly builds enable netavark specific tests Update release notes for v4.0.2 Bump to v4.0.2 Marc Nguyen (1): [NO NEW TESTS NEEDED] rootless: declare TEMP_FAILURE_RETRY before usage (Fixes: #12563) Mark Zhang (1): Update basic_networking.md Markus Thömmes (3): Display help text on empty subcommand by default Adjust tests to verify all subcommands show the help message Keep error semantics intact Matej Vasek (14): Fix /auth compat endpoint fix inverted condition Set DOCKER_HOST in the VM Fix libpod API conformance to swagger Use correct swagger type in doc-comment Better emptiness test for custom JSON serializer More conforming libpod API and swagger types More conforming libpod API and swagger types Fix swagger definitions Add tests Update swagger doc make filed optional fix: error reporting for archive endpoint fix: parsing of HostConfig.Mounts for container create Add IndexConfigs to compat /info endpoint Matthew Heon (38): Add a backoff and retries to retrieving exited event Ensure pod ID bucket is properly updated on rename Update README and release notes for v3.4.0 Allow `podman stop` to be run on Stopping containers Ensure `podman ps --sync` functions Remove infra ID from DB before removing containers Warn on failing to update container status Always run passwd management code when DB value is nil Bump to v4.0.0-RC1 Bump to v4.0.0-dev Revamp Libpod state strings for Docker compat Update release notes for Podman v4.0.0 Final release notes for v4.0.0-rc2 Bump to v4.0.0-RC2 Bump to v4.0.0-dev Fix Cirrus destination branch Update release notes for v4.0.0-RC3 Bump to v4.0.0-RC3 Bump to v4.0.0-dev Remove mention of IPv6 portfwd from release notes Update release notes for v4.0.0-RC4 Disable failing E2E test Bump to v4.0.0-RC4 Bump to v4.0.0-dev Modify /etc/resolv.conf when connecting/disconnecting Update release notes for v4.0.0-RC5 Bump to v4.0.0-RC5 Bump to v4.0.0-dev Revert minimum API change Fix lint Release notes for v4.0.0 final Bump to v4.0.0 Bump to v4.0.1-dev Remove the runtime lock Fix a potential flake in volume plugins tests Update release notes for v4.0.1 Bump to v4.0.1 Bump to v4.0.2-dev Matthew Mosesohn (1): Add podman-plugins to upstream image Michael Hrivnak (1): [CI:DOCS] fixes indentation of example pod yaml Michael Scherer (2): Always create working directory when using compat API Change error message for compatibility with docker Miloslav Trmač (39): Use INTEGRATION_ROOT instead of current directory Tighten the expected output of the "podman image trust show" test Fix tests of podman image trust --raw and --json Move a comment to the relevant place Don't use the global math/rand RNG for service ports Allow containerPortsToServicePorts to fail Ensure the generated NodePort values are unique Improve documentation of (podman image save --format) Fix documentation of (podman image save --compress --uncompressed) Add unit tests for multiAuthHeader Add unit tests for singleAuthHeader Improve TestAuthConfigsToAuthFile Add tests for auth.Header Add TestHeaderGetCredentialsRoundtrip Rename normalize and a few variables Fix normalizeAuthFileKey to use the correct semantics Don't return a header name from auth.GetCredentials Simplify the interface of parseSingleAuthHeader Simplify parseSingleAuthHeader Pass a header value directly to parseSingleAuthHeader and parseMultiAuthHeader Beautify GetCredentials.has a bit Use Header.Values in GetCredentials.has Only look up HTTP header values once in GetCredentials Consolidate the error handling path in GetCredentials Move the auth file creation to GetCredentials Turn headerConfig into MakeXRegistryConfigHeader Call MakeXRegistryConfigHeader instead of Header(..., XRegistryConfigHeader) Turn headerAuth into MakeXRegistryAuthHeader Call MakeXRegistryAuthHeader instead of Header(..., XRegistryAuthHeader) Remove pkg/auth.Header Consolidate creation of SystemContext with auth.json into a helper Remove no-longer-useful name variables Remove the authfile parameter of MakeXRegistryConfigHeader Simplify the header decision in pkg/bindings/images.Build a bit Remove the authfile parameter of MakeXRegistryAuthHeader Make XRegistryAuthHeader and XRegistryConfigHeader private Refactor remote socket path determination in tests Avoid collisions on RemoteSocket paths Don't initialize the global RNG with GinkgoRandomSeed() in e2e tests Moritz "WanzenBug" Wanzenböck (1): bindings: reuse context for API requests Morten Linderud (1): create: Fix key=value annotation in the flag output Nalin Dahyabhai (8): build: take advantage of --platform lists Update docs for --platform in podman-build.1 remote build: EvalSymlinks() the context directory Use exponential backoff when waiting for a journal entry tweak a couple of flag descriptions in help output journald logs: keep reading until the journal's end pkg/bindings/images.Build(): slashify "dockerfile" values, too Document `schema` values in the `--url` flag Noah Stride (1): fix misleading comment regarding default value of cpu period [NO NEW TESTS NEEDED] Oliver (1): prefix imageId with sha256: in containers list Ondra Machacek (3): Handle HTTP 409 error messages properly for Pod actions Add restart-sec option to systemd generate Fix nil pointer dereference for configmap optional Patrycja Guzik (4): Fix filter description and unify filters docs for containers/images prune Unify podman prune filter description: volumes, networks, system Adapt podman images ls filters docs to be aligned with prune filters docs Unify ls --filter docs for networks and pods Paul Holzinger (120): remove rootlessport socket to prevent EADDRINUSE bump c/common to v0.44.0 fix restart always with rootlessport libpod: rootful close binded ports Fix example in podman machine init man page container runlabel remove image tag from name network create: validate the input subnet default network: do not validate the used subnets cni network configs set ipv6 enables correctly Wire network interface into libpod Drop OCICNI dependency CI: load ipv6 kernel modules for rootless tests Add Drivers method to the Network Interface Do not allow network modes to be used as network names CNI: network create support macvlan modes CNI: add ipvlan driver Only add 127.0.0.1 entry to /etc/hosts with --net=none Use a new markdown converter for sphinx Remove unused code from libpod podman machine: use gvproxy for host.containers.internal compat API: /images/json prefix image id with sha256 Bump CNI to v1.0.1 net types: remove omitempty from required fields sync container state before reading the healthcheck podman inspect add State.Health field for docker compat shell completion: do not show images without tag Revert "rootful: unset XDG_RUNTIME_DIR" rootful: do not set XDG_RUNTIME_DIR for cni plugins podman machine: do not join userns CNI: network remove do not error for ENOENT fix podman network prune integration test flakes always add short container id as net alias set --cni-config-dir for exit command move network alias validation to container create bump c/common to latest and c/storage to 1.37.0 CNI networks: reload networks if needed libpod: fix race when closing STDIN podman stats: move cgroup validation to server rootlessport: reduce memory usage of the process CNI: fix network create --ip-range Fix panic in container create compat api Document to not set K8S envars for CNI Slirp4netns with ipv6 set net.ipv6.conf.default.accept_dad=0 libpod: deduplicate ports in db MAC address json unmarshal should allow strings Fix bindings container log test Fix rootless cni netns cleanup logic mount full XDG_RUNTIME_DIR in rootless cni ns rename rootless cni ns to rootless netns Fix swagger definition for the new mac address type pod create: read network mode from config Fix rootless networking with userns and ports network reload without ports should not reload ports network reload return error if we cannot reload ports Fix flake in upgrade tests Make networking code reusable netavark network interface netavark IPAM assignment Fix RUST_LOG envar for netavark select network backend based on config Add more netavark tests Add network backend to podman info Add flag to overwrite network backend from config Add failing run test for netavark Fix network mode in play kube podman machine improve port forwarding podman machine start wait for ssh rename libpod nettypes fields rootless netns, one netns per libpod tmp dir Do not store the exit command in container config fix duplicated logs command Make sure netavark output is logged to the syslog Force iptables driver for netavark tests Fix netavark error handling and teardown issue checkpoint do not modify XDG_RUNTIME_DIR Fix possible rootless netns cleanup race rootless netns: resolve all path components for resolv.conf fix e2e test missing network cleanup network ls: show networks in deterministic order network db rewrite: migrate existing settings remove unneeded return value from c.Networks() network db: add new strucutre to container create network connect allow ip, ipv6 and mac address fix incorrect swagger doc for network dis/connect Add new networks format to spegecen support advanced network configuration via cli play kube add support for multiple networks container restore/import: store networks from db specgen: check that networks are only set with bridge fix network id handling bump cobra to 1.3.0 MovePauseProcessToScope do not seed everytime add --ip6 flag to podman create/run fix host.containers.internal entry for macvlan networks use libnetwork from c/common update buildah to latest and use new network stack use netns package from c/common upgrade test: check that network backend is cni fix buildah-bud test diff podman build enable --all-platforms and --unsetenv update c/common to latest upgrade all dependencies rename --cni-config-dir to --network-config-dir Remove rootless_networking option from containers.conf container create: do not check for network dns support remote build: set rootless oci isolation correctly network create: allow multiple subnets github: label issues based on os github: label issues based on os fix regex system prune: remove all networks Revert "Move each search dns to its own line" append podman dns search domain move rootless netns slirp4netns process to systemd user.slice Show API doc for several versions Do not set the network config dir to cni plugin dir podman network: add documentation for netavark Load ip_tables modules at boot system tests: cleanup networks on teardown use GetRuntimeDir() from c/common provide better error on invalid flag Pavel Dostál (1): Fix wrong 'podman search --format' placeholder Praveen Kumar (1): Fix help message case for `podman version` Radostin Stoyanov (7): Add --file-locks checkpoint/restore option Add test for checkpoint/restore with --file-locks test: Update error string for --file-locks test api/handlers: Add checkpoint/restore FileLocks Update github.com/checkpoint-restore/checkpointctl Enable checkpoint/restore for /dev/shm e2e: Add dev/shm checkpoint/restore test Reinhard Tartler (1): [CI:DOCS] oci-hooks.5.md: fixup section in header Riyad Preukschas (1): Prevent double decoding of storage options Romain Geissler (1): Option --url and --connection should imply --remote. Sankalp Rangare (1): added healthcheck to ps command Sascha Grunert (1): Exclude already built sources for static build Shion Tanaka (1): Fixed the containerfile not found during remote build. Stefan Weil (3): Replace 'an user' => 'a user' Fix some typos in documentation and comments (found by codespell) [NO NEW TESTS NEEDED] Fix off-by-one index comparision (reported by LGTM) Stephen Person (1): Update docker cli message for case where user creates directory Tom Deseyn (1): [NO NEW TEST NEEDED] Add schema for ImageCreate 200 response. TomSweeneyRedHat (4): [CI:DOCS] Add network alias note in man pages [CI:DOCS] Add link to running ctrimage on enablesysadm [CI:DOCS] Add java TZ note to run manpage Update Windows Install Doc Tsubasa Watanabe (1): Add notes to "--oom-kill-disable" not supported on cgroups V2 Urvashi Mohnani (13): [CI:DOCS] Add link to skopeo delete in podman rmi [NO TESTS NEEDED] Add port configuration to first regular container Allow a value of -1 to set unlimited pids limit Add expose type map[uint16]string to description Add note about empty fields and null values for API responses Don't add image entrypoint to the generate kube yaml Do not add TCP to protocol in generated kube yaml Set targetPort to the port value in the kube yaml Print headers for system connection ls Add note about volume with unprivileged container [CI:DOCS] Update notes on java TZ in man page Add support for configmap volumes to play kube Don't add env if optional and not found Valentin Rothberg (67): remote untag: support digests vendor c/common@main vendor c/[email protected] podman save: add `--uncompressed` podman save: enforce signature removal image prune: support removing external containers [CI:DOCS] cmd/podman: no dot for short descriptions libpod: do not call (*container).Config() libpod: do not call (*container).Spec() libpod: add execSessionNoCopy libpod: add GetConfigNoCopy() libpod: container create: init variable: do not deep copy spec cirrus: gitlab: download packages pkg/specgen: cache image in generator faster image inspection podman search: display only name and description by default overlay root fs: create mount on runtime dir cirrus: containers: mount directory in /var/tmp to /tmp add kubernetes pause pod create: remove need for pause image container create: fix --tls-verify parsing volumes: be more tolerant and fix infinite loop pod/container create: resolve conflicts of generated names support health checks from image configs pod create: read infra image from containers.conf podman load: support downloading files play kube: don't force-pull infra image Revert "add kubernetes pause" infra container: replace pause with catatonit cirrus: force-install catatonit fix remote checkpoint/restore fix CI remote checkpoint/restore: more fixes generate systemd: add --start-timeout flag image lookup: do not match *any* tags compat API: allow enforcing short-names resolution to Docker Hub systemd: replace multi-user with default.target top: parse ps(1) args correctly compat: images/json vendor c/common@main e2e: fix pprof flakes fix remote run/start flake vendor c/image/v5@main remove runlabel test for global opts generate systemd: support entrypoint JSON strings inotify: make sure to remove files pprof CI flakes: enforce 5 seconds grace period compat build: adhere to q/quiet pprof flakes: bump timeout to 20 seconds pause scope: don't use the global math/rand RNG e2e: search flake: skip test on registry.redhat.io kill: fix output bindings rmi test: clarify behavior image rm: allow for force-remove infra images apiv2 tests: use quay.io/libpod/testimage:20210610 for platform tests compat: image normalization: handle sha256 prefix support hosts without /etc/hosts [CI:DOCS] clarify `io.podman.annotations.seccomp` container creation: don't apply reserved annotations from image vendor c/common vendor latest c/common podman container rm: remove pod bump go module to version 4 compat attach: fix write on closed channel apiv2 test: add regression test for #12904 vendor c/[email protected] e2e: merge after/since image-filter tests Yahav Itzhak (1): Fix Zsh completion command documentation baude (1): Use new aarch64 fcos repos bazhang87 (1): Update troubleshooting.md cdoern (19): Pod Volumes Support Created MapOptions for PodCreate Pod Device Support Pod Device-Read-BPS support Pod Volumes From Support Pod Events Logging Fix Kube Gen run as user/group issues Pod Rm Infra Improvements Podman Image SCP rootful to rootless transfer Podman Image SCP transfer patch Podman run --passwd podman image scp never enter podman user NS Pod Security Option support Podman Pod Create --sysctl support Prohibit --uid/gid map and --pod for container create/run Podman Build use absolute filepath switch podman image scp from depending on machinectl to just os/exec podman image scp syntax correction Podman pod create --share-parent vs --share=cgroup chenkang (2): Support readonly rootfs contains colon fix test dependabot[bot] (24): Bump github.com/json-iterator/go from 1.1.11 to 1.1.12 Bump k8s.io/api from 0.22.1 to 0.22.2 Bump github.com/mattn/go-isatty from 0.0.12 to 0.0.14 Bump github.com/containers/buildah from 1.23.0 to 1.23.1 Bump github.com/docker/docker Bump github.com/containers/image/v5 from 5.16.0 to 5.16.1 Bump github.com/opencontainers/selinux from 1.8.5 to 1.9.1 Bump github.com/onsi/ginkgo from 1.16.4 to 1.16.5 Bump github.com/docker/docker Bump k8s.io/api from 0.22.2 to 0.22.3 Bump github.com/checkpoint-restore/go-criu/v5 from 5.1.0 to 5.2.0 Bump k8s.io/api from 0.22.3 to 0.22.4 Bump github.com/docker/docker Bump github.com/opencontainers/selinux from 1.9.1 to 1.10.0 Bump github.com/containers/image/v5 from 5.16.1 to 5.17.0 Bump github.com/opencontainers/runc from 1.0.2 to 1.0.3 Bump github.com/uber/jaeger-client-go Bump github.com/docker/docker Bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0 Bump github.com/opencontainers/runc from 1.0.3 to 1.1.0 Bump github.com/opencontainers/runc from 1.0.3 to 1.1.0 Bump github.com/containers/storage from 1.38.0 to 1.38.1 Bump github.com/containers/image/v5 from 5.18.0 to 5.19.0 Bump github.com/buger/goterm from 1.0.1 to 1.0.4 esendjer (2): Handlers for `generate systemd` with custom dependencies ignition: propagate proxy settings from a host into a vm etenzy (1): fix: take absolute path for dd on apple silicon flouthoc (1): rootfs: Add support for rootfs-overlay and bump to buildah v1.22.1-0.202108 fredr (1): troubleshooting links to main branch myml (2): Fix: Do not print error when parsing journald log fails fix: Multiplication of durations tomsweeneyredhat (2): Bump Buildah to v1.24.0 [v4.0] Bump c/common to v0.47.4 wangqiang (1): Hostname in `spec.hostname` should be passed to infra ctr init opt ye.sijun (1): fix doc Дилян Палаузов (1): Makefile: use -ldflags/-gccgoflags depending on the go implemenatiton 二氟化氧 (1): [CI:DOCS]upload a translation file 荒野無燈 (1): fix(generate): fix up podman generate kube missing env field bug

openshift-ci Bot added the approved label Aug 27, 2021

nalind force-pushed the subdirectory-exclusions branch 2 times, most recently from 8332966 to 03fa38e Compare August 27, 2021 21:13

nalind force-pushed the subdirectory-exclusions branch from 03fa38e to 807ba3e Compare August 30, 2021 12:40

nalind commented Aug 30, 2021

View reviewed changes

Comment thread tests/add.bats Outdated

nalind force-pushed the subdirectory-exclusions branch from 807ba3e to b43359e Compare August 30, 2021 14:45

nalind added 2 commits August 30, 2021 11:04

copy: add --max-parallel-downloads to tune that copy option

239fc6f

Add a --max-parallel-downloads flag to allow tuning down from the default of six blobs at a time, and tune it down to one at a time when we invoke the helper. Signed-off-by: Nalin Dahyabhai <[email protected]>

nalind force-pushed the subdirectory-exclusions branch from b43359e to 239fc6f Compare August 30, 2021 15:04

vrothberg approved these changes Aug 31, 2021

View reviewed changes

openshift-ci Bot assigned vrothberg Aug 31, 2021

openshift-ci Bot added the lgtm label Aug 31, 2021

openshift-merge-robot merged commit bfd3f69 into containers:main Aug 31, 2021

nalind deleted the subdirectory-exclusions branch August 31, 2021 13:31

nalind mentioned this pull request Sep 14, 2021

Bump github.com/containers/buildah from 1.22.3 to 1.23.0 containers/podman#11568

Closed

Luap99 mentioned this pull request Sep 15, 2021

vendor: Bump github.com/containers/buildah from 1.22.3 to 1.23.0 containers/podman#11585

Merged

flouthoc added a commit to flouthoc/podman that referenced this pull request Sep 15, 2021

build.bats: fix copy tests after containers/buildah#3486

962675c

Fix copy tests after containers/buildah#3486 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <[email protected]>

edsantiago mentioned this pull request Sep 15, 2021

ignorefile: wildcard behaves differently depending on unrelated ignore lines #3520

Closed

mheon pushed a commit to mheon/libpod that referenced this pull request Sep 16, 2021

build.bats: fix copy tests after containers/buildah#3486

03bd1ff

Fix copy tests after containers/buildah#3486 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <[email protected]>

mheon pushed a commit to mheon/libpod that referenced this pull request Sep 16, 2021

build.bats: fix copy tests after containers/buildah#3486

c7c4cb8

Fix copy tests after containers/buildah#3486 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <[email protected]>

github-actions Bot added the locked - please file new issue/PR label Sep 16, 2023

github-actions Bot locked as resolved and limited conversation to collaborators Sep 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

copier.Get(): try to avoid descending into directories#3486

copier.Get(): try to avoid descending into directories#3486
openshift-merge-robot merged 2 commits intocontainers:mainfrom
nalind:subdirectory-exclusions

nalind commented Aug 27, 2021 •

edited

Loading

Uh oh!

rhatdan commented Aug 27, 2021

Uh oh!

TomSweeneyRedHat commented Aug 28, 2021

Uh oh!

Uh oh!

TomSweeneyRedHat commented Aug 30, 2021

Uh oh!

vrothberg left a comment

Uh oh!

openshift-ci Bot commented Aug 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

nalind commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

rhatdan commented Aug 27, 2021

Uh oh!

TomSweeneyRedHat commented Aug 28, 2021

Uh oh!

Uh oh!

TomSweeneyRedHat commented Aug 30, 2021

Uh oh!

vrothberg left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nalind commented Aug 27, 2021 •

edited

Loading