bug: return errors when iptables and ip6tables are unusable#712
Merged
dcbw merged 1 commit intocontainernetworking:mainfrom May 4, 2022
Merged
bug: return errors when iptables and ip6tables are unusable#712dcbw merged 1 commit intocontainernetworking:mainfrom
dcbw merged 1 commit intocontainernetworking:mainfrom
Conversation
joejulian
force-pushed
the
joe/add_error_output
branch
3 times, most recently
from
3f6ae79 to
8e8f06d
Compare
mars1024
reviewed
Mar 8, 2022
joejulian
force-pushed
the
joe/add_error_output
branch
2 times, most recently
from
77b9503 to
f90abab
Compare
Signed-off-by: Joe Julian <[email protected]>
joejulian
force-pushed
the
joe/add_error_output
branch
from
f90abab to
e3d563b
Compare
Member
|
/lgtm (I thought about error wrapping, but since both the errors are at the same level, not sure that makes as much sense...) |
Contributor
Author
I considered it, as well, but then thought the same. |
mars1024
approved these changes
Apr 27, 2022
Member
mars1024
left a comment
mars1024
left a comment
There was a problem hiding this comment.
/lgtm
(forget about the error wrapping)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a problem occurs accessing both iptables and ip6tables in portmap, return an error that contains the origin errors.
Fixes #711