Skip to content

call ipam.ExecDel after clean up device in netns#702

Merged
dcbw merged 1 commit intocontainernetworking:masterfrom
gojoy:master
Mar 2, 2022
Merged

call ipam.ExecDel after clean up device in netns#702
dcbw merged 1 commit intocontainernetworking:masterfrom
gojoy:master

Conversation

@gojoy
Copy link
Copy Markdown
Contributor

@gojoy gojoy commented Feb 14, 2022

call ipam.ExecDel to release ip in ipam after clean up device in netns.,avoid ip conflict
fix #666

Signed-off-by: gojoy [email protected]

@gojoy gojoy marked this pull request as ready for review February 14, 2022 03:04
Comment thread plugins/main/bridge/bridge.go Outdated
@gojoy gojoy changed the title call ipam.ExceDel after clean up device in netns call ipam.ExecDel after clean up device in netns Feb 17, 2022
@gojoy gojoy requested a review from dcbw February 17, 2022 06:19
@dcbw
Copy link
Copy Markdown
Member

dcbw commented Feb 23, 2022

@gojoy could squash the new commit into the first one, so that the DCO is OK?

@dcbw
Copy link
Copy Markdown
Member

dcbw commented Feb 23, 2022

@gojoy and can you git rm the bridge plugin binary that seems to have crept into the commit?

@gojoy
Copy link
Copy Markdown
Contributor Author

gojoy commented Feb 27, 2022

@gojoy could squash the new commit into the first one, so that the DCO is OK?

done

@gojoy
Copy link
Copy Markdown
Contributor Author

gojoy commented Feb 27, 2022

@gojoy and can you git rm the bridge plugin binary that seems to have crept into the commit?

done

@dcbw
Copy link
Copy Markdown
Member

dcbw commented Mar 2, 2022

/lgtm

@squeed
Copy link
Copy Markdown
Member

squeed commented Mar 2, 2022

lgtm, thanks

@dcbw dcbw merged commit b8a10bb into containernetworking:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bridge plugin:call ipam.ExecDel after clean device in netns

3 participants