portmap: fix iptables conditions detection#1117
Merged
squeed merged 1 commit intocontainernetworking:mainfrom Dec 2, 2024
Merged
portmap: fix iptables conditions detection#1117squeed merged 1 commit intocontainernetworking:mainfrom
squeed merged 1 commit intocontainernetworking:mainfrom
Conversation
champtar
force-pushed
the
portmap-detectBackendOfConditions-fix
branch
2 times, most recently
from
c50b94c to
402e194
Compare
Contributor
Author
|
Tested with |
Contributor
|
ah, oops, yes |
Contributor
|
(ah, lol, there's no |
champtar
force-pushed
the
portmap-detectBackendOfConditions-fix
branch
from
402e194 to
cf2f081
Compare
Contributor
Author
|
@squeed this one is also ready to be merged (just rebased) |
As show in the docs, iptables conditions can also start with '!' Fixes 01a94e1 Signed-off-by: Etienne Champetier <[email protected]>
champtar
force-pushed
the
portmap-detectBackendOfConditions-fix
branch
from
cf2f081 to
ccac6de
Compare
Contributor
Author
|
@danwinship @squeed rebased and ready to merge |
squeed
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As show in the docs, iptables conditions can also start with '!'
Fixes 01a94e1
Fixes #1114