Use temporary name for netdevice when moving in/out of NS#1002
Merged
s1061123 merged 1 commit intocontainernetworking:mainfrom Mar 12, 2024
Merged
Use temporary name for netdevice when moving in/out of NS#1002s1061123 merged 1 commit intocontainernetworking:mainfrom
s1061123 merged 1 commit intocontainernetworking:mainfrom
Conversation
adrianchiris
force-pushed
the
use-temp-name
branch
3 times, most recently
from
8dd7158 to
90db66c
Compare
Contributor
Author
s1061123
requested changes
Mar 11, 2024
Contributor
s1061123
left a comment
s1061123
left a comment
There was a problem hiding this comment.
@adrianchiris sorry to review this. It looks good to me almost code. Regarding error handling, I added one comment. could you please take a look into it? Thanks!
|
|
||
| tempDev, err := setTempName(hostDev) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to rename device %q to temporary name: %v", hostDevName, err) |
Contributor
There was a problem hiding this comment.
If moveLinkIn() is called with interface Up and failed at here (or later), then the interface goes down and not up. I suppose to add the code to revert (i.e. LinkSetUp()) at error-return case.
Contributor
Author
There was a problem hiding this comment.
added logic to restore netdev:
- bring back to host namespace
- retore netdev name
- restore link status
adrianchiris
force-pushed
the
use-temp-name
branch
from
cabb009 to
9cde7a3
Compare
Today, it is not possible to use host-device CNI to move a host device to container namespace if a device already exists in that namespace. e.g when a delegate plugin (such as multus) is used to provide multiple networks to a container, CNI Add call will fail if the targeted host device name already exists in container network namespace. to overcome this, we use a temporary name for the interface before moving it in/out of container network namespace. Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
use-temp-name
branch
from
9cde7a3 to
ba5bdaf
Compare
Contributor
Author
|
@s1061123 thx for reviewing. comment addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, it is not possible to use host-device CNI to move a
host device to container namespace if a device with the same
netdev name already exists in that namespace.
e.g when a delegate plugin (such as multus) is used to provide
multiple networks to a container, CNI Add call will fail if
the targeted host device name already exists in container network
namespace.
to overcome this, we use a temporary name for the interface before
moving it in/out of container network namespace.