Skip to content

Fix: Use our fork of go-skynet for all Skynet Ops#82

Merged
guacamole merged 1 commit intomasterfrom
skynet-lib-fix
Dec 9, 2021
Merged

Fix: Use our fork of go-skynet for all Skynet Ops#82
guacamole merged 1 commit intomasterfrom
skynet-lib-fix

Conversation

@jay-dee7
Copy link
Member

@jay-dee7 jay-dee7 commented Dec 5, 2021

Fixes #79 - from here on we use our fork of skynet maintained at
Containerish's Fork of Skynet Go SDK

Signed-off-by: jay-dee7 [email protected]

@jay-dee7 jay-dee7 requested a review from guacamole December 5, 2021 09:23
@jay-dee7 jay-dee7 self-assigned this Dec 5, 2021
Fixes #79 - from here on we use our fork of skynet maintained at
[Containerish's Fork of Skynet Go SDK](https://github.com/containerish/go-skynet.git)

Signed-off-by: jay-dee7 <[email protected]>
@jay-dee7 jay-dee7 linked an issue Dec 5, 2021 that may be closed by this pull request
@jay-dee7
Copy link
Member Author

jay-dee7 commented Dec 5, 2021

@vbatts I hope it's okay. We're switching to our fork of go-skynet, which is up-to-date with the official implementation of go-skynet

Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! 💯

@guacamole
Copy link
Member

Good to merge,
We'll wait for @vbatts to get back to see if he has anything to add..

@vbatts
Copy link

vbatts commented Dec 9, 2021

Oh, no worries from me. I was just browsing over the project, and saw something that could be tidy'ed up 😸

@jay-dee7
Copy link
Member Author

jay-dee7 commented Dec 9, 2021

Haha thanks a ton. Please let us know if there's something else you noticed (any implementation error, etc) we'd love to fix it up :)

@guacamole lets merge this one?

@guacamole
Copy link
Member

@jay-dee7 , Awesome!!! Merging it..

@guacamole guacamole merged commit 85b6b7d into master Dec 9, 2021
@guacamole guacamole deleted the skynet-lib-fix branch December 9, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

update which skynet package is used

3 participants