Skip to content

add: enhanced sign-in experience#51

Merged
jay-dee7 merged 1 commit intomasterfrom
signin-enhancements
Oct 21, 2021
Merged

add: enhanced sign-in experience#51
jay-dee7 merged 1 commit intomasterfrom
signin-enhancements

Conversation

@guacamole
Copy link
Member

  • User can now signin using email or username
  • Added extra checks to cover edge cases

Signed-off-by: guacamole [email protected]

- User can now signin using email or username
- Added extra checks to cover edge cases

Signed-off-by: guacamole <[email protected]>
@guacamole guacamole requested a review from jay-dee7 October 21, 2021 13:49
@guacamole guacamole self-assigned this Oct 21, 2021
@guacamole
Copy link
Member Author

Screenshot 2021-10-21 at 7 51 02 PM

- The ocr conformance tests are passing on local - Issue has been opened to solve it in a different PR

Copy link
Member

@jay-dee7 jay-dee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @guacamole LGTM 🥇

@jay-dee7 jay-dee7 merged commit 7347f97 into master Oct 21, 2021
@jay-dee7 jay-dee7 deleted the signin-enhancements branch October 21, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants