Skip to content

Added missing endpoints and fixed delete endpoints /w auth#4

Merged
guacamole merged 1 commit intomasterfrom
missing-endpoints
Jul 10, 2021
Merged

Added missing endpoints and fixed delete endpoints /w auth#4
guacamole merged 1 commit intomasterfrom
missing-endpoints

Conversation

@jay-dee7
Copy link
Member

@jay-dee7 jay-dee7 commented Jul 10, 2021

Signed-off-by: jay-dee7 [email protected]

  • Get Manifest endpoint was deleted accidentally, so this PR adds it back
  • We now close req bodies immediately after reading them
  • Added Delete (Image, Layer) endpoints, but they don't delete anything yet (since deleting is kind of tricky on SkyNet)

@jay-dee7 jay-dee7 requested a review from guacamole July 10, 2021 12:52
@jay-dee7 jay-dee7 self-assigned this Jul 10, 2021
guacamole
guacamole approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@guacamole guacamole merged commit dc6477d into master Jul 10, 2021
@guacamole guacamole deleted the missing-endpoints branch July 10, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guacamole guacamole guacamole approved these changes

Assignees

@jay-dee7 jay-dee7

Labels

None yet

Projects

Containerish Road Map 2023-24
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jay-dee7 @guacamole