Merged
Conversation
guacamole
force-pushed
the
github-actions
branch
22 times, most recently
from
3fa5f55 to
f48307e
Compare
Signed-off-by: gunjan valecha <[email protected]> Signed-off-by: guacamole <[email protected]>
guacamole
force-pushed
the
github-actions
branch
from
f48307e to
6de3c0c
Compare
jay-dee7
approved these changes
Aug 31, 2021
Member
jay-dee7
left a comment
jay-dee7
left a comment
There was a problem hiding this comment.
@guacamole LGTM 🥇
the tests are failing but thats only because we didn't fix all the conformance test cases. we should be good to merge this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gunjan valecha [email protected]
This pull request fixes issue #3