Fix: removed io.ReadAll from entire project#114
Merged
Conversation
Member
guacamole
commented
Mar 6, 2022
guacamole
commented
- removed all but one occurrences of io.ReadAll from the project
- this pr fixes Replace io.ReadAll with a more memory efficient method #89
- the only occurrence is assured to cause no problems since it's reading a request body of a small size, will still work on finding a better solution
- replaced ctx.Request().Body with resp which is skylink for image manifest - this is a get method, does not contain any body
guacamole
force-pushed
the
remove-ioReadAll
branch
from
667f203 to
bfb5354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.