Skip to content

Fix: Skynet Portal URL from config file#113

Merged
jay-dee7 merged 1 commit intomasterfrom
config-fix
Mar 6, 2022
Merged

Fix: Skynet Portal URL from config file#113
jay-dee7 merged 1 commit intomasterfrom
config-fix

Conversation

@jay-dee7
Copy link
Member

@jay-dee7 jay-dee7 commented Mar 6, 2022

config file declares the portal url as:

skynet:
  portal_url: https://siasky.net

but the datatype was declared with tag skynet_portal_url which was causing the url defined in the config file to be reset to default always since skynet sdk defaults to siasky.net when skynet url is empty

@jay-dee7 jay-dee7 requested a review from guacamole March 6, 2022 11:26
@jay-dee7 jay-dee7 self-assigned this Mar 6, 2022
@jay-dee7 jay-dee7 added the bug Something isn't working label Mar 6, 2022
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@jay-dee7 jay-dee7 merged commit 3d9dccc into master Mar 6, 2022
@jay-dee7 jay-dee7 deleted the config-fix branch March 6, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants