Skip to content

Add containerd project checks to CI#38

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
austinvazquez:pin-dependencies
Nov 8, 2022
Merged

Add containerd project checks to CI#38
dmcgowan merged 1 commit intocontainerd:mainfrom
austinvazquez:pin-dependencies

Conversation

@austinvazquez
Copy link
Copy Markdown
Member

@austinvazquez austinvazquez commented Oct 26, 2022

Add containerd project checks to CI

Signed-off-by: Austin Vazquez [email protected]

@austinvazquez austinvazquez marked this pull request as ready for review October 26, 2022 15:53
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp
Copy link
Copy Markdown
Member

Can we move this repo to use the project-checks action instead?

@estesp
Copy link
Copy Markdown
Member

estesp commented Oct 27, 2022

Can we move this repo to use the project-checks action instead?

Hmm, good point. Looks like this subproject never got moved to the project-checks action. @austinvazquez do you mind updating this workflow to use the project-checks?

@austinvazquez
Copy link
Copy Markdown
Member Author

Can we move this repo to use the project-checks action instead?

Hmm, good point. Looks like this subproject never got moved to the project-checks action. @austinvazquez do you mind updating this workflow to use the project-checks?

+1 will update.

@austinvazquez austinvazquez marked this pull request as draft November 8, 2022 17:27
@austinvazquez austinvazquez changed the title Pin dependencies in CI workflow Add containerd project checks to CI Nov 8, 2022
@austinvazquez austinvazquez marked this pull request as ready for review November 8, 2022 17:30
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 123160d into containerd:main Nov 8, 2022
@austinvazquez austinvazquez deleted the pin-dependencies branch November 8, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants