Skip to content

Rename any to anyType#36

Merged
estesp merged 2 commits intocontainerd:mainfrom
kzys:any-rename
May 3, 2022
Merged

Rename any to anyType#36
estesp merged 2 commits intocontainerd:mainfrom
kzys:any-rename

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented May 2, 2022

Go 1.18 makes any an alias to interface {}. While having any struct works in Go 1.18, this may be confusing for developers.

Kazuyoshi Kato added 2 commits May 2, 2022 21:29
Go 1.18 makes `any` an alias to `interface {}`. While having `any`
struct works in Go 1.18, this may be confusing for developers.

Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 2, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.90%. Comparing base (bac36d3) to head (c30a36c).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   68.90%   68.90%           
=======================================
  Files           1        1           
  Lines         119      119           
=======================================
  Hits           82       82           
  Misses         28       28           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 51c7356 into containerd:main May 3, 2022
@AkihiroSuda
Copy link
Copy Markdown
Member

Can we create a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants