Make Any type an interface#32
Merged
mxpv merged 1 commit intocontainerd:mainfrom Mar 21, 2022
Merged
Conversation
Make the any type an interface which supports both Any structs from Gogo protobuf and Google protobuf as well as a typeurl implementation. Signed-off-by: Derek McGowan <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 59.63% 63.30% +3.66%
==========================================
Files 1 1
Lines 109 109
==========================================
+ Hits 65 69 +4
+ Misses 37 33 -4
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kzys
approved these changes
Mar 21, 2022
Member
mxpv
approved these changes
Mar 21, 2022
kzys
pushed a commit
to kzys/imgcrypt
that referenced
this pull request
Mar 22, 2022
typeurl.MarshalAny returns typeurl.Any since containerd/typeurl#32. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
pushed a commit
to kzys/imgcrypt
that referenced
this pull request
Mar 22, 2022
typeurl.MarshalAny returns typeurl.Any since containerd/typeurl#32. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
pushed a commit
to kzys/typeurl
that referenced
this pull request
Mar 24, 2022
Make Any type an interface Signed-off-by: Kazuyoshi Kato <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the any type an interface which supports both Any structs from
Gogo protobuf and Google protobuf as well as a typeurl implementation.